Issue 20026: Sandbox: Add support for Windows 7 - 64 bit....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20026: Sandbox: Add support for Windows 7 - 64 bit.... (Closed)

Created:
11 years, 10 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Sandbox: Add support for Windows 7 - 64 bit. BUG=4324 TEST=IntegrationTestsTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9104

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -15 lines)			Patch
	M	sandbox/src/service_resolver.cc	View		5 chunks	+42 lines, -12 lines	1 comment	Download
	M	sandbox/wow_helper/service64_resolver.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

is the change from the previous patch in the sizeof? if so, lgtm. if not, ...

11 years, 10 months ago (2009-02-03 21:20:35 UTC) #2

rvargas (doing something else)

11 years, 10 months ago (2009-02-03 21:26:23 UTC) #3

http://codereview.chromium.org/20026/diff/1/2
File sandbox/src/service_resolver.cc (right):

http://codereview.chromium.org/20026/diff/1/2#newcode267
Line 267: sizeof(intercepted_code));
This is the new line.

Expand Messages | Collapse Messages