Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2002443002: Bail out of resetting a URL's engagement if the URL is not valid. (Closed)

Created:
4 years, 7 months ago by dominickn
Modified:
4 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bail out of resetting a URL's engagement if the URL is not valid. This speculatively addresses a DCHECK failure when the history service expires a URL on startup and notifies the site engagement service of it. Occasionally, the URL sent to site engagement is invalid, triggering the DCHECK. BUG=612881 Committed: https://crrev.com/b30352f5c5bb51c5be8d3e147080729794f1d6a3 Cr-Commit-Position: refs/heads/master@{#394991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/engagement/site_engagement_service.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
dominickn
PTAL, thanks
4 years, 7 months ago (2016-05-20 02:21:07 UTC) #2
calamity
lgtm
4 years, 7 months ago (2016-05-20 02:35:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002443002/1
4 years, 7 months ago (2016-05-20 02:36:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 03:55:34 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 03:57:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b30352f5c5bb51c5be8d3e147080729794f1d6a3
Cr-Commit-Position: refs/heads/master@{#394991}

Powered by Google App Engine
This is Rietveld 408576698