Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 200243002: Expose FrameDetails and ScopeDetails from its Mirrors. (Closed)

Created:
6 years, 9 months ago by aandrey
Modified:
6 years, 9 months ago
Reviewers:
ulan, yangguo, yurys
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Expose FrameDetails and ScopeDetails from its Mirrors. We in fact already access these via the private property "details_". Make it into the API. R=ulan@chromium.org, yurys@chromium.org, ulan, yangguo, yurys Committed: https://code.google.com/p/v8/source/detail?r=19938

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/mirror-debugger.js View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aandrey
6 years, 9 months ago (2014-03-14 11:46:56 UTC) #1
ulan
lgtm
6 years, 9 months ago (2014-03-14 12:03:09 UTC) #2
yurys
lgtm
6 years, 9 months ago (2014-03-14 12:22:58 UTC) #3
yurys
6 years, 9 months ago (2014-03-14 15:10:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r19938 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698