src/core/SkOpts.cpp - Issue 2002423002: [GN] Add support for disabling opts via SK_BUILD_NO_OPTS define.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkOpts.cpp

Issue 2002423002: [GN] Add support for disabling opts via SK_BUILD_NO_OPTS define. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkOpts.cpp

diff --git a/src/core/SkOpts.cpp b/src/core/SkOpts.cpp

index c6ff43b532dcf015b868a92ac870dfd6b7995a26..6d3e6c9feac4073b68b47d4dd8ac1c475fbb7b81 100644

--- a/src/core/SkOpts.cpp

+++ b/src/core/SkOpts.cpp

@@ -84,8 +84,7 @@ namespace SkOpts {

void Init_avx2() {}

static void init() {

- // TODO: Chrome's not linking _sse* opts on iOS simulator builds. Bug or feature?

- #if defined(SK_CPU_X86) && !defined(SK_BUILD_FOR_IOS)

+ #if defined(SK_CPU_X86) && !defined(SK_BUILD_NO_OPTS)

if (SkCpu::Supports(SkCpu::SSSE3)) { Init_ssse3(); }

if (SkCpu::Supports(SkCpu::SSE41)) { Init_sse41(); }

if (SkCpu::Supports(SkCpu::SSE42)) { Init_sse42(); }

« no previous file with comments | « public.bzl ('k') | tests/SkBlend_optsTest.cpp » ('j') | no next file with comments »