Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: gyp/common_conditions.gypi

Issue 2002423002: [GN] Add support for disabling opts via SK_BUILD_NO_OPTS define. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « experimental/iOSSampleApp/iOSSampleApp.xcodeproj/project.pbxproj ('k') | include/core/SkPreConfig.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 21f4c92398a10e35ef8aa5ee0bdd9875ac39e73c..4f387e988380c165e62e08706474f4e08c29688d 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -562,7 +562,12 @@
[ 'skia_os == "ios"',
{
'defines': [
+ # When targetting iOS and using gyp to generate the build files, it is
+ # not possible to select files to build depending on the architecture
+ # (i.e. it is not possible to use hand optimized assembly version). In
+ # that configuration, disable all optimisation.
'SK_BUILD_FOR_IOS',
+ 'SK_BUILD_NO_OPTS',
],
'conditions' : [
[ 'skia_warnings_as_errors', {
« no previous file with comments | « experimental/iOSSampleApp/iOSSampleApp.xcodeproj/project.pbxproj ('k') | include/core/SkPreConfig.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698