Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2002413002: Revert of Deduplicating code performing WebHTTPBody::Element conversions. (Closed)

Created:
4 years, 6 months ago by kolos1
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, clamy, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Deduplicating code performing WebHTTPBody::Element conversions. (patchset #7 id:120001 of https://codereview.chromium.org/1987053002/ ) Reason for revert: This CL causes failures in content_browsertests and browser_tests (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/54314 ) BUG=614299 Original issue's description: > Deduplicating code performing WebHTTPBody::Element conversions. > > Before this CL, there were 2 separate structs in //content layer holding > essentially the same information about parts of http body: > ResourceRequestBody::Element and ExplodedHttpBodyElement. > > To deal with 2 separate structs, recent CLs had to introduce duplicated, > copy & pasted code that performed conversions between WebHTTPBody::Element > from the Blink layer and the 2 structs in the //content layer. > Examples: > > 1. https://crrev.com/1956383003: > 1.a. AddHTTPBodyToRequest in //content/renderer/render_frame_impl.cc > duplicated code from //content/renderer/history_serialization.cc > > 2. https://crrev.com/1907443006: > 2.a. Almost exactly the same as above, AddHTTPBodyToRequest in > //content/renderer/render_frame_impl.cc duplicated code from > //content/renderer/history_serialization.cc > 2.b. ResourceRequestBody::AppendExplodedHTTPBodyElement in > //content/common/resource_request_body.cc was duplicating > > The current CL removes the duplicated code by making > ExplodedHttpBodyElement a type alias for ResourceRequestBody::Element > and removing code that dealt with the old ExplodedHttpBodyElement > struct. > > BUG=582211 > > Committed: https://crrev.com/2d0c9ae694afcb5c16028222e206b64aaba0cdba > Cr-Commit-Position: refs/heads/master@{#395461} TBR=creis@chromium.org,lukasza@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=582211 Committed: https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518 Cr-Commit-Position: refs/heads/master@{#395548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -198 lines) Patch
M content/common/page_state_serialization.h View 2 chunks +16 lines, -2 lines 0 comments Download
M content/common/page_state_serialization.cc View 8 chunks +48 lines, -44 lines 0 comments Download
M content/common/page_state_serialization_unittest.cc View 3 chunks +25 lines, -23 lines 0 comments Download
M content/common/resource_request_body.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/resource_request_body.cc View 1 chunk +44 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/page_state.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/history_serialization.cc View 5 chunks +52 lines, -6 lines 0 comments Download
D content/renderer/http_body_conversions.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/renderer/http_body_conversions.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +29 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kolos1
Created Revert of Deduplicating code performing WebHTTPBody::Element conversions.
4 years, 6 months ago (2016-05-24 08:55:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002413002/1
4 years, 6 months ago (2016-05-24 08:55:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-24 08:56:17 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-05-24 08:57:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518
Cr-Commit-Position: refs/heads/master@{#395548}

Powered by Google App Engine
This is Rietveld 408576698