DescriptionRevert of Deduplicating code performing WebHTTPBody::Element conversions. (patchset #7 id:120001 of https://codereview.chromium.org/1987053002/ )
Reason for revert:
This CL causes failures in content_browsertests and browser_tests (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/54314
)
BUG=614299
Original issue's description:
> Deduplicating code performing WebHTTPBody::Element conversions.
>
> Before this CL, there were 2 separate structs in //content layer holding
> essentially the same information about parts of http body:
> ResourceRequestBody::Element and ExplodedHttpBodyElement.
>
> To deal with 2 separate structs, recent CLs had to introduce duplicated,
> copy & pasted code that performed conversions between WebHTTPBody::Element
> from the Blink layer and the 2 structs in the //content layer.
> Examples:
>
> 1. https://crrev.com/1956383003:
> 1.a. AddHTTPBodyToRequest in //content/renderer/render_frame_impl.cc
> duplicated code from //content/renderer/history_serialization.cc
>
> 2. https://crrev.com/1907443006:
> 2.a. Almost exactly the same as above, AddHTTPBodyToRequest in
> //content/renderer/render_frame_impl.cc duplicated code from
> //content/renderer/history_serialization.cc
> 2.b. ResourceRequestBody::AppendExplodedHTTPBodyElement in
> //content/common/resource_request_body.cc was duplicating
>
> The current CL removes the duplicated code by making
> ExplodedHttpBodyElement a type alias for ResourceRequestBody::Element
> and removing code that dealt with the old ExplodedHttpBodyElement
> struct.
>
> BUG=582211
>
> Committed: https://crrev.com/2d0c9ae694afcb5c16028222e206b64aaba0cdba
> Cr-Commit-Position: refs/heads/master@{#395461}
TBR=creis@chromium.org,lukasza@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=582211
Committed: https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518
Cr-Commit-Position: refs/heads/master@{#395548}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|