[MD settings] remove settings_page.css

[MD settings] remove settings_page.css

This CL moves the contents of settings_page.css into a new style-module
called settings_page_css.html. A var is created for the page top padding
to be shared with the section padding and the main page behavior. Along
the way a correction is made to use the new padding value (21px vs 24px).

BUG=589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6b10bd64cc5a729bd826e9161fbd626ece40cbba
Cr-Commit-Position: refs/heads/master@{#396279}

[dschuyler, 2016-05-23 23:56:22]

Description was changed from

==========
[MD settings] remove settings_page.css

This CL moves the contents of settings_page.css into a new style-module
called settings_page_css.html. A var is created for the page top padding
to be shared with the section padding and the main page behavior. Along
the way a correction is made to use the new padding value (21px vs 24px).

BUG=589630
==========

to

==========
[MD settings] remove settings_page.css

This CL moves the contents of settings_page.css into a new style-module
called settings_page_css.html. A var is created for the page top padding
to be shared with the section padding and the main page behavior. Along
the way a correction is made to use the new padding value (21px vs 24px).

BUG=589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-05-24 00:02:24]

dschuyler@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2016-05-25 18:27:47]

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.html:24: <link
rel="import" type="css" href="chrome://md-settings/settings_page.css">
kill

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.html
(right):

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.html:20:
min-height: 100%;
pretty sure this was calc'd for a reason, what's changed?

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page_css.html (right):

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page_css.html:28: /* Account for
padding in settings_page.css. */
fix comment

[dschuyler, 2016-05-25 21:16:18]

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/about_page/about_page.html (right):

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/about_page/about_page.html:24: <link
rel="import" type="css" href="chrome://md-settings/settings_page.css">
On 2016/05/25 18:27:47, michaelpg wrote:
> kill

Done.

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.html
(right):

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.html:20:
min-height: 100%;
On 2016/05/25 18:27:47, michaelpg wrote:
> pretty sure this was calc'd for a reason, what's changed?

The margin change is accounted for in settings_page_css.html.

What was the calc +48px for? I haven't 
found any difference by adding or removing it.

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page_css.html (right):

https://codereview.chromium.org/2002353002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page_css.html:28: /* Account for
padding in settings_page.css. */
On 2016/05/25 18:27:47, michaelpg wrote:
> fix comment

Done.

[michaelpg, 2016-05-25 21:30:27]

lgtm

https://codereview.chromium.org/2002353002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/main_page_behavior.html
(right):

https://codereview.chromium.org/2002353002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/main_page_behavior.html:20:
min-height: 100%;
probably not needed because of the above rule

[dschuyler, 2016-05-25 23:04:40]

https://codereview.chromium.org/2002353002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/main_page_behavior.html
(right):

https://codereview.chromium.org/2002353002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/main_page_behavior.html:20:
min-height: 100%;
On 2016/05/25 21:30:26, michaelpg wrote:
> probably not needed because of the above rule

Done.

[dschuyler, 2016-05-26 18:12:59]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-05-26 18:12:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2002353002/#ps40001
(title: "review changes")

[commit-bot: I haz the power, 2016-05-26 18:13:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002353002/40001

[commit-bot: I haz the power, 2016-05-26 19:04:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 19:04:38]

Failed to apply patch for
chrome/browser/resources/settings/about_page/about_page.html:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/browser/resources/settings/about_page/about_page.html:5
  Falling back to three-way merge...
  Applied patch to
'chrome/browser/resources/settings/about_page/about_page.html' with conflicts.
  U chrome/browser/resources/settings/about_page/about_page.html

Patch:       chrome/browser/resources/settings/about_page/about_page.html
Index: chrome/browser/resources/settings/about_page/about_page.html
diff --git a/chrome/browser/resources/settings/about_page/about_page.html
b/chrome/browser/resources/settings/about_page/about_page.html
index
4e1244831e3d379fed325741fa3cc5a3915838fb..e7ba2a83d4e0c2632d30b80825982a34eb77ef01
100644
--- a/chrome/browser/resources/settings/about_page/about_page.html
+++ b/chrome/browser/resources/settings/about_page/about_page.html
@@ -5,6 +5,7 @@
 <link rel="import"
href="chrome://md-settings/settings_page/main_page_behavior.html">
 <link rel="import"
href="chrome://md-settings/settings_page/settings_animated_pages.html">
 <link rel="import"
href="chrome://md-settings/settings_page/settings_section.html">
+<link rel="import" href="chrome://md-settings/settings_page_css.html">
 <link rel="import" href="chrome://md-settings/settings_shared_css.html">
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 <link rel="import" href="chrome://resources/html/assert.html">
@@ -20,9 +21,8 @@
 </if>
 
 <dom-module id="settings-about-page">
-  <link rel="import" type="css" href="chrome://md-settings/settings_page.css">
   <template>
-    <style include="settings-shared main-page-styles">
+    <style include="settings-shared settings-page-styles">
       span {
         font-size: 20px;
         margin-top: auto;

[commit-bot: I haz the power, 2016-05-26 19:04:44]

The CQ bit was unchecked by commit-bot@chromium.org

[dschuyler, 2016-05-26 19:10:58]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-05-26 19:10:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2002353002/#ps60001
(title: "merge with master")

[commit-bot: I haz the power, 2016-05-26 19:11:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002353002/60001

[commit-bot: I haz the power, 2016-05-26 20:55:56]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-26 20:57:18]

Description was changed from

==========
[MD settings] remove settings_page.css

This CL moves the contents of settings_page.css into a new style-module
called settings_page_css.html. A var is created for the page top padding
to be shared with the section padding and the main page behavior. Along
the way a correction is made to use the new padding value (21px vs 24px).

BUG=589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] remove settings_page.css

This CL moves the contents of settings_page.css into a new style-module
called settings_page_css.html. A var is created for the page top padding
to be shared with the section padding and the main page behavior. Along
the way a correction is made to use the new padding value (21px vs 24px).

BUG=589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6b10bd64cc5a729bd826e9161fbd626ece40cbba
Cr-Commit-Position: refs/heads/master@{#396279}
==========

[commit-bot: I haz the power, 2016-05-26 20:57:19]

Patchset 4 (id:??) landed as
https://crrev.com/6b10bd64cc5a729bd826e9161fbd626ece40cbba
Cr-Commit-Position: refs/heads/master@{#396279}