content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h - Issue 2002303002: Consolidate OutputSurface constructors into GL vs Vulkan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

Issue 2002303002: Consolidate OutputSurface constructors into GL vs Vulkan. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: outputsurface-constructors: rebase-and-fixcrash Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/compositor/browser_compositor_output_surface.cc ('k') | content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

diff --git a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

index a5233033c9e488827f4f56fa94ae4f520dbbf7eb..a7cbf1f017338f97a2cbd6c2a58e53a53c0ce914 100644

--- a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

+++ b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

@@ -51,9 +51,9 @@ class GpuSurfacelessBrowserCompositorOutputSurface

gfx::SwapResult result,

const gpu::GpuProcessHostedCALayerTreeParamsMac* params_mac) override;

- unsigned int internalformat_;

+ const unsigned int internalformat_;

std::unique_ptr<display_compositor::GLHelper> gl_helper_;

- std::unique_ptr<display_compositor::BufferQueue> output_surface_;

+ std::unique_ptr<display_compositor::BufferQueue> buffer_queue_;

gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager_;

};