[Media Router] Allow casting new media to sink with existing route.

chrome/browser/resources/media_router/media_router.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="media_router_data.js">
 <include src="media_router_ui_interface.js">
 
 // Handles user events for the Media Router UI.
 cr.define('media_router', function() {
   'use strict';
@@ skipping 19 matching lines @@
     media_router.ui.setElements(container,
         /** @type {!MediaRouterHeaderElement} */
         (container.$['container-header']));
 
     container.addEventListener('acknowledge-first-run-flow',
                                onAcknowledgeFirstRunFlow);
     container.addEventListener('back-click', onNavigateToSinkList);
     container.addEventListener('cast-mode-selected', onCastModeSelected);
     container.addEventListener('close-dialog', onCloseDialog);
     container.addEventListener('close-route-click', onCloseRouteClick);
+    container.addEventListener('close-route-for-new-media',
+                               onCloseRouteForNewMedia);

[amp, 2016/05/23 21:42:35]

Can't this reuse the onCloseRouteClick handler as well?  The code looks
identical.

Or would that not conform to some style guide?

[btolsch, 2016/05/23 22:41:10]

It is identical, but I wasn't sure if it would be bad style to use
onCloseRouteClick. If others are ok with reusing it, I'm fine with it too.

[apacible, 2016/05/25 00:56:34]

Reusing onCloseRouteClick is fine.

     container.addEventListener('create-route', onCreateRoute);
     container.addEventListener('issue-action-click', onIssueActionClick);
     container.addEventListener('navigate-sink-list-to-details',
                                onNavigateToDetails);
     container.addEventListener('navigate-to-cast-mode-list',
                                onNavigateToCastMode);
     container.addEventListener('report-filter', onFilter);
     container.addEventListener('report-initial-action', onInitialAction);
     container.addEventListener('report-initial-action-close',
                                onInitialActionClose);
@@ skipping 164 matching lines @@
    * Parameters in |event|.detail:
    *   route - The route to close.
    */
   function onCloseRouteClick(event) {
     /** @type {{route: !media_router.Route}} */
     var detail = event.detail;
     media_router.browserApi.closeRoute(detail.route);
   }
 
   /**
+   * Stops a route.
+   * Called when the user requests to cast to a sink that already has a route.
+   *
+   * @param {!Event} event
+   * Parameters in |event|.detail:
+   *   route - The route to close.
+   */
+  function onCloseRouteForNewMedia(event) {
+    /** @type {{route: !media_router.Route}} */
+    var detail = event.detail;
+    media_router.browserApi.closeRoute(detail.route);
+  }
+
+  /**
    * Starts casting to an existing route.
    * Called when the user requests to start casting to a media route.
    *
    * @param {!Event} event
    * Parameters in |event|.detail:
    *   route - The route to connect to if possible.
    */
   function onStartCastingToRouteClick(event) {
     /** @type {{route: !media_router.Route}} */
     var detail = event.detail;
@@ skipping 128 matching lines @@
   function onWindowBlur() {
     media_router.browserApi.reportBlur();
   }
 
   return {
     initialize: initialize,
   };
 });
 
 window.addEventListener('load', media_router.initialize);