Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2002253004: Add warning message when disabling ARC. (Closed)

Created:
4 years, 7 months ago by dspaid
Modified:
4 years, 6 months ago
Reviewers:
mitsuji, stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add warning message when disabling ARC. BUG=610941 TEST=cros autotest to be submitted in https://chrome-internal-review.googlesource.com/#/c/262336 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2b1b13921cd0291635484827eba0d879926365ec Cr-Commit-Position: refs/heads/master@{#399824}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Formatting #

Patch Set 4 : revert unrelated changes by git cl format #

Total comments: 1

Patch Set 5 : Updated wording #

Patch Set 6 : rebase #

Patch Set 7 : temporarily remove .css file to fix patch #

Patch Set 8 : re-add .css file #

Patch Set 9 : fix css copy detection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1 line) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/resources/options/chromeos/arc_opt_out_confirm_overlay.css View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/browser/resources/options/chromeos/arc_opt_out_confirm_overlay.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
dspaid
4 years, 6 months ago (2016-06-03 06:58:14 UTC) #4
stevenjb
lgtm w/ text change suggestion https://codereview.chromium.org/2002253004/diff/60001/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2002253004/diff/60001/chrome/app/chromeos_strings.grdp#newcode6613 chrome/app/chromeos_strings.grdp:6613: Apps you've downloaded from ...
4 years, 6 months ago (2016-06-08 00:41:42 UTC) #6
dspaid
Hiro, Any comments on the suggested text change? This is based on your mocks.
4 years, 6 months ago (2016-06-08 02:31:56 UTC) #8
dspaid
On 2016/06/08 00:41:42, stevenjb wrote: > lgtm w/ text change suggestion > > https://codereview.chromium.org/2002253004/diff/60001/chrome/app/chromeos_strings.grdp > ...
4 years, 6 months ago (2016-06-08 22:51:25 UTC) #9
mitsuji
On 2016/06/08 22:51:25, dspaid wrote: > On 2016/06/08 00:41:42, stevenjb wrote: > > lgtm w/ ...
4 years, 6 months ago (2016-06-09 21:02:27 UTC) #10
mitsuji
On 2016/06/08 22:51:25, dspaid wrote: > On 2016/06/08 00:41:42, stevenjb wrote: > > lgtm w/ ...
4 years, 6 months ago (2016-06-09 21:02:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002253004/160001
4 years, 6 months ago (2016-06-14 22:53:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios-device-gn on ...
4 years, 6 months ago (2016-06-15 00:54:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002253004/160001
4 years, 6 months ago (2016-06-15 00:56:30 UTC) #18
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 6 months ago (2016-06-15 02:53:44 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 02:56:50 UTC) #21
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/2b1b13921cd0291635484827eba0d879926365ec
Cr-Commit-Position: refs/heads/master@{#399824}

Powered by Google App Engine
This is Rietveld 408576698