[turbofan] Properly connect DeoptimizeIf/Unless to effect chain.

src/compiler/branch-elimination.cc

Index: src/compiler/branch-elimination.cc
diff --git a/src/compiler/branch-elimination.cc b/src/compiler/branch-elimination.cc
index 427612c36e1152f916750d71336f560d88795309..6d5dad8a214c1c0b973c726af25390135f43e7a8 100644
--- a/src/compiler/branch-elimination.cc
+++ b/src/compiler/branch-elimination.cc
@@ -101,15 +101,15 @@ Reduction BranchElimination::ReduceDeoptimizeConditional(Node* node) {
     if (condition_is_true == condition_value.FromJust()) {
       // We don't to update the conditions here, because we're replacing with

[Jarin, 2016/05/24 11:06:09]

Since you are here, could you make this an english sentence?

[Benedikt Meurer, 2016/05/24 11:06:25]

Done.

       // the {control} node that already contains the right information.
-      return Replace(control);
+      ReplaceWithValue(node, dead(), effect, control);
     } else {
       control = graph()->NewNode(common()->Deoptimize(DeoptimizeKind::kEager),
                                  frame_state, effect, control);
       // TODO(bmeurer): This should be on the AdvancedReducer somehow.
       NodeProperties::MergeControlToEnd(graph(), common(), control);
       Revisit(graph()->end());
-      return Replace(dead());
     }
+    return Replace(dead());
   }
   return UpdateConditions(
       node, conditions->AddCondition(zone_, condition, condition_is_true));