[turbofan] Properly connect DeoptimizeIf/Unless to effect chain.

[turbofan] Properly connect DeoptimizeIf/Unless to effect chain.

The DeoptimizeIf and DeoptimizeUnless operators should actually produce
an effect in addition to the control output.

R=jarin@chromium.org

Committed: https://crrev.com/1dace25984d2856ff3075072bbabcd12df81d098
Cr-Commit-Position: refs/heads/master@{#36477}

[Benedikt Meurer, 2016-05-24 11:00:15]

Hey Jaro,

Here's the fix we discussed.
Please take a look.

Thanks,
Benedikt

[Jarin, 2016-05-24 11:06:09]

lgtm

https://codereview.chromium.org/2002253003/diff/1/src/compiler/branch-elimina...
File src/compiler/branch-elimination.cc (right):

https://codereview.chromium.org/2002253003/diff/1/src/compiler/branch-elimina...
src/compiler/branch-elimination.cc:102: // We don't to update the conditions
here, because we're replacing with
Since you are here, could you make this an english sentence?

[Benedikt Meurer, 2016-05-24 11:06:25]

https://codereview.chromium.org/2002253003/diff/1/src/compiler/branch-elimina...
File src/compiler/branch-elimination.cc (right):

https://codereview.chromium.org/2002253003/diff/1/src/compiler/branch-elimina...
src/compiler/branch-elimination.cc:102: // We don't to update the conditions
here, because we're replacing with
On 2016/05/24 11:06:09, Jarin wrote:
> Since you are here, could you make this an english sentence?

Done.

[Benedikt Meurer, 2016-05-24 11:06:30]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-05-24 11:06:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002253003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002253003/20001

[commit-bot: I haz the power, 2016-05-24 11:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 11:25:51]

Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng_trigg...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/6217)
  v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[Benedikt Meurer, 2016-05-24 12:38:17]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-05-24 12:38:17]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2002253003/#ps40001
(title: "Fix JSCallReducer")

[commit-bot: I haz the power, 2016-05-24 12:38:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002253003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002253003/40001

[commit-bot: I haz the power, 2016-05-24 13:16:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-24 13:17:37]

Description was changed from

==========
[turbofan] Properly connect DeoptimizeIf/Unless to effect chain.

The DeoptimizeIf and DeoptimizeUnless operators should actually produce
an effect in addition to the control output.

R=jarin@chromium.org
==========

to

==========
[turbofan] Properly connect DeoptimizeIf/Unless to effect chain.

The DeoptimizeIf and DeoptimizeUnless operators should actually produce
an effect in addition to the control output.

R=jarin@chromium.org

Committed: https://crrev.com/1dace25984d2856ff3075072bbabcd12df81d098
Cr-Commit-Position: refs/heads/master@{#36477}
==========

[commit-bot: I haz the power, 2016-05-24 13:17:38]

Patchset 3 (id:??) landed as
https://crrev.com/1dace25984d2856ff3075072bbabcd12df81d098
Cr-Commit-Position: refs/heads/master@{#36477}