Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1156)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mash/wm/shelf_layout_manager.cc

Issue 2002243002: Gets mash to use WmToplevelWindowEventHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix registration Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mash/wm/frame/move_event_handler.cc ('K') | « mash/wm/root_window_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/wm/shelf_layout_manager.cc
diff --git a/mash/wm/shelf_layout_manager.cc b/mash/wm/shelf_layout_manager.cc
index 44fb732b40bd848e4b1675d43a870094612c0e5c..76ae4559c964b53868c503e7da1097aa020bef98 100644
--- a/mash/wm/shelf_layout_manager.cc
+++ b/mash/wm/shelf_layout_manager.cc
@@ -35,7 +35,7 @@ mus::Window* ShelfLayoutManager::GetShelfWindow() {
void ShelfLayoutManager::LayoutWindow(mus::Window* window) {
if (GetAshWindowType(window) != mojom::AshWindowType::SHELF) {
- NOTREACHED() << "Unknown window in USER_SHELF container.";
+ // Phanton windows end up in this container, ignore them.
James Cook 2016/05/23 21:53:34 nit: Phanton -> Phantom
sky 2016/05/23 22:23:26 Done.
return;
}
gfx::Size size = GetWindowPreferredSize(window);
« mash/wm/frame/move_event_handler.cc ('K') | « mash/wm/root_window_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698