src/runtime/runtime-object.cc - Issue 2002203002: [api] Add more parameters to Object::GetPropertyNames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-object.cc

Issue 2002203002: [api] Add more parameters to Object::GetPropertyNames (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2016-05-06_keys_fast_path_1995263002

Patch Set: addressing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-object.cc

diff --git a/src/runtime/runtime-object.cc b/src/runtime/runtime-object.cc

index 2b096054f3718d0436837aba3db5e2525e9f2ec9..9bef97df2ac737079d50cc449cdc066db3b68965 100644

--- a/src/runtime/runtime-object.cc

+++ b/src/runtime/runtime-object.cc

@@ -563,7 +563,8 @@ RUNTIME_FUNCTION(Runtime_GetOwnPropertyKeys) {

Handle<FixedArray> keys;

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

isolate, keys,

- KeyAccumulator::GetKeys(object, OWN_ONLY, filter, CONVERT_TO_STRING));

+ KeyAccumulator::GetKeys(object, KeyCollectionMode::kOwnOnly, filter,

+ GetKeysConversion::kConvertToString));

return *isolate->factory()->NewJSArrayWithElements(keys);

}

« no previous file with comments | « src/runtime/runtime-forin.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »