src/json-stringifier.cc - Issue 2002203002: [api] Add more parameters to Object::GetPropertyNames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/json-stringifier.cc

Issue 2002203002: [api] Add more parameters to Object::GetPropertyNames (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2016-05-06_keys_fast_path_1995263002

Patch Set: addressing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/json-stringifier.cc

diff --git a/src/json-stringifier.cc b/src/json-stringifier.cc

index b38c7807bd9530cd7afbf60196a9b34e7e7bb196..061c910363ecf2c9bbc6317f621f02e75b3453d1 100644

--- a/src/json-stringifier.cc

+++ b/src/json-stringifier.cc

@@ -537,7 +537,8 @@ JsonStringifier::Result JsonStringifier::SerializeJSReceiverSlow(

if (contents.is_null()) {

ASSIGN_RETURN_ON_EXCEPTION_VALUE(

isolate_, contents,

- KeyAccumulator::GetKeys(object, OWN_ONLY, ENUMERABLE_STRINGS),

+ KeyAccumulator::GetKeys(object, KeyCollectionMode::kOwnOnly,

+ ENUMERABLE_STRINGS),

EXCEPTION);

}

builder_.AppendCharacter('{');

« no previous file with comments | « src/elements.cc ('k') | src/keys.h » ('j') | no next file with comments »