Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: src/debug/debug-scopes.cc

Issue 2002203002: [api] Add more parameters to Object::GetPropertyNames (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2016-05-06_keys_fast_path_1995263002
Patch Set: addressing nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug-scopes.h ('k') | src/elements.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug-scopes.cc
diff --git a/src/debug/debug-scopes.cc b/src/debug/debug-scopes.cc
index 391a6cfe8f0f185d302e2a718bdc1293aa2fe12d..b93af34d4101748dee7d3b4626ba80448ab371e3 100644
--- a/src/debug/debug-scopes.cc
+++ b/src/debug/debug-scopes.cc
@@ -494,7 +494,7 @@ MaybeHandle<JSObject> ScopeIterator::MaterializeLocalScope() {
if (function_context->closure() == *function &&
!function_context->IsNativeContext()) {
CopyContextExtensionToScopeObject(function_context, local_scope,
- INCLUDE_PROTOS);
+ KeyCollectionMode::kIncludePrototypes);
}
return local_scope;
@@ -520,7 +520,8 @@ Handle<JSObject> ScopeIterator::MaterializeClosure() {
// Finally copy any properties from the function context extension. This will
// be variables introduced by eval.
- CopyContextExtensionToScopeObject(context, closure_scope, OWN_ONLY);
+ CopyContextExtensionToScopeObject(context, closure_scope,
+ KeyCollectionMode::kOwnOnly);
return closure_scope;
}
@@ -571,7 +572,8 @@ Handle<JSObject> ScopeIterator::MaterializeInnerScope() {
if (!context.is_null()) {
// Fill all context locals.
CopyContextLocalsToScopeObject(CurrentScopeInfo(), context, inner_scope);
- CopyContextExtensionToScopeObject(context, inner_scope, OWN_ONLY);
+ CopyContextExtensionToScopeObject(context, inner_scope,
+ KeyCollectionMode::kOwnOnly);
}
return inner_scope;
}
@@ -764,11 +766,11 @@ void ScopeIterator::CopyContextLocalsToScopeObject(
void ScopeIterator::CopyContextExtensionToScopeObject(
Handle<Context> context, Handle<JSObject> scope_object,
- KeyCollectionType type) {
+ KeyCollectionMode mode) {
if (context->extension_object() == nullptr) return;
Handle<JSObject> extension(context->extension_object());
Handle<FixedArray> keys =
- KeyAccumulator::GetKeys(extension, type, ENUMERABLE_STRINGS)
+ KeyAccumulator::GetKeys(extension, mode, ENUMERABLE_STRINGS)
.ToHandleChecked();
for (int i = 0; i < keys->length(); i++) {
« no previous file with comments | « src/debug/debug-scopes.h ('k') | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698