include/v8.h - Issue 2002203002: [api] Add more parameters to Object::GetPropertyNames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 2002203002: [api] Add more parameters to Object::GetPropertyNames (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2016-05-06_keys_fast_path_1995263002

Patch Set: remove debug code Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index b5db5fe4295d11d17589fdeb07fefdbf2cde7e81..04b2396691ab7372e34740ad10d7f6f672240fc6 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -2631,6 +2631,10 @@ enum PropertyFilter {

SKIP_SYMBOLS = 16

};

+enum class KeyCollectionMode { kOwnOnly, kIncludePrototypes };

Igor Sheludko 2016/05/30 13:35:37 This is a public API, we probably need some commen

+enum class IndexFilter { kIncludeIndices, kSkipIndices };

/**

* Integrity level for objects.

@@ -2780,6 +2784,9 @@ class V8_EXPORT Object : public Value {

V8_DEPRECATE_SOON("Use maybe version", Local<Array> GetPropertyNames());

V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetPropertyNames(

Local<Context> context);

+ V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetPropertyNames(

+ Local<Context> context, KeyCollectionMode mode,

+ PropertyFilter property_filter, IndexFilter index_filter);

/**

* This function has the same functionality as GetPropertyNames but

« no previous file with comments | « no previous file | src/api.cc » ('j') | test/cctest/test-api.cc » ('J')