[api] Add more parameters to Object::GetPropertyNames

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index b5db5fe4295d11d17589fdeb07fefdbf2cde7e81..04b2396691ab7372e34740ad10d7f6f672240fc6 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -2631,6 +2631,10 @@ enum PropertyFilter {
   SKIP_SYMBOLS = 16
 };
 
+enum class KeyCollectionMode { kOwnOnly, kIncludePrototypes };

[Yang, 2016/05/30 09:25:28]

Do we actually have a consistent way of naming enums? we have both UPPER_CASE
and kCamelCase enum names in v8.h. Initially, I thought UPPER_CASE are enums
that we use as bitfields. But then you got StackTrace::StackTraceOptions and
PropertyAttribute.

:(

[Camillo Bruni, 2016/05/30 11:25:45]

yeah I was confused as well. Apparently "enum" used uppercase, while "enum
class" use the k prefix...

+
+enum class IndexFilter { kIncludeIndices, kSkipIndices };
+
 /**
  * Integrity level for objects.
  */
@@ -2780,6 +2784,9 @@ class V8_EXPORT Object : public Value {
   V8_DEPRECATE_SOON("Use maybe version", Local<Array> GetPropertyNames());
   V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetPropertyNames(

[Yang, 2016/05/30 09:25:28]

Why don't we just extend this with default args?

[Camillo Bruni, 2016/05/30 11:25:45]

Just followed the rest of the api here...

       Local<Context> context);
+  V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetPropertyNames(
+      Local<Context> context, KeyCollectionMode mode,
+      PropertyFilter property_filter, IndexFilter index_filter);
 
   /**
    * This function has the same functionality as GetPropertyNames but