[api] Add more parameters to Object::GetPropertyNames

src/keys.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_KEYS_H_
 #define V8_KEYS_H_
 
 #include "src/isolate.h"
 #include "src/objects.h"
 
@@ skipping 13 matching lines @@
 // collected in |string_properties_|, a single OrderedHashSet (similar for
 // Symbols in |symbol_properties_|. To separate the keys per level later when
 // assembling the final list, |levelLengths_| keeps track of the number of
 // String and Symbol keys per level.
 //
 // Only unique keys are kept by the KeyAccumulator, strings are stored in a
 // HashSet for inexpensive lookups. Integer keys are kept in sorted lists which
 // are more compact and allow for reasonably fast includes check.
 class KeyAccumulator final BASE_EMBEDDED {
  public:
-  KeyAccumulator(Isolate* isolate, KeyCollectionType type,
+  KeyAccumulator(Isolate* isolate, KeysCollectionLimit type,

[Igor Sheludko, 2016/05/25 14:52:56]

I would rename |type| here, below and above as well.

                  PropertyFilter filter)
       : isolate_(isolate), type_(type), filter_(filter) {}
   ~KeyAccumulator();
 
   static MaybeHandle<FixedArray> GetKeys(
-      Handle<JSReceiver> object, KeyCollectionType type, PropertyFilter filter,
-      GetKeysConversion keys_conversion = KEEP_NUMBERS,
+      Handle<JSReceiver> object, KeysCollectionLimit type,
+      PropertyFilter filter, GetKeysConversion keys_conversion = KEEP_NUMBERS,
       bool filter_proxy_keys = true, bool is_for_in = false);
   Handle<FixedArray> GetKeys(GetKeysConversion convert = KEEP_NUMBERS);
   Maybe<bool> CollectKeys(Handle<JSReceiver> receiver,
                           Handle<JSReceiver> object);
   Maybe<bool> CollectOwnElementIndices(Handle<JSReceiver> receiver,
                                        Handle<JSObject> object);
   Maybe<bool> CollectOwnPropertyNames(Handle<JSReceiver> receiver,
                                       Handle<JSObject> object);
 
   static Handle<FixedArray> GetEnumPropertyKeys(Isolate* isolate,
@@ skipping 22 matching lines @@
 
   Maybe<bool> AddKeysFromJSProxy(Handle<JSProxy> proxy,
                                  Handle<FixedArray> keys);
 
   Handle<OrderedHashSet> keys() { return Handle<OrderedHashSet>::cast(keys_); }
 
   Isolate* isolate_;
   // keys_ is either an Handle<OrderedHashSet> or in the case of own JSProxy
   // keys a Handle<FixedArray>.
   Handle<FixedArray> keys_;
-  KeyCollectionType type_;
+  KeysCollectionLimit type_;
   PropertyFilter filter_;
   bool filter_proxy_keys_ = true;
   bool is_for_in_ = false;
   bool skip_indices_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(KeyAccumulator);
 };
 
 // The FastKeyAccumulator handles the cases where there are no elements on the
 // prototype chain and forwords the complex/slow cases to the normal
 // KeyAccumulator.
 class FastKeyAccumulator {
  public:
   FastKeyAccumulator(Isolate* isolate, Handle<JSReceiver> receiver,
-                     KeyCollectionType type, PropertyFilter filter)
+                     KeysCollectionLimit type, PropertyFilter filter)
       : isolate_(isolate), receiver_(receiver), type_(type), filter_(filter) {
     Prepare();
   }
 
   bool is_receiver_simple_enum() { return is_receiver_simple_enum_; }
   bool has_empty_prototype() { return has_empty_prototype_; }
   void set_filter_proxy_keys(bool filter) { filter_proxy_keys_ = filter; }
   void set_is_for_in(bool value) { is_for_in_ = value; }
 
   MaybeHandle<FixedArray> GetKeys(GetKeysConversion convert = KEEP_NUMBERS);
 
  private:
   void Prepare();
   MaybeHandle<FixedArray> GetKeysFast(GetKeysConversion convert);
   MaybeHandle<FixedArray> GetKeysSlow(GetKeysConversion convert);
 
   Isolate* isolate_;
   Handle<JSReceiver> receiver_;
-  KeyCollectionType type_;
+  KeysCollectionLimit type_;
   PropertyFilter filter_;
   bool filter_proxy_keys_ = true;
   bool is_for_in_ = false;
   bool is_receiver_simple_enum_ = false;
   bool has_empty_prototype_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(FastKeyAccumulator);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_KEYS_H_