[api] Add more parameters to Object::GetPropertyNames

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** \mainpage V8 API Reference Guide
  *
  * V8 is Google's open source JavaScript engine.
  *
  * This set of documents provides reference material generated from the
  * V8 header file, include/v8.h.
@@ skipping 2613 matching lines @@
  */
 enum PropertyFilter {
   ALL_PROPERTIES = 0,
   ONLY_WRITABLE = 1,
   ONLY_ENUMERABLE = 2,
   ONLY_CONFIGURABLE = 4,
   SKIP_STRINGS = 8,
   SKIP_SYMBOLS = 16
 };
 
+enum class KeyCollectionMode { kOwnOnly, kIncludePrototypes };

[Yang, 2016/05/30 09:25:28]

Do we actually have a consistent way of naming enums? we have both UPPER_CASE
and kCamelCase enum names in v8.h. Initially, I thought UPPER_CASE are enums
that we use as bitfields. But then you got StackTrace::StackTraceOptions and
PropertyAttribute.

:(

[Camillo Bruni, 2016/05/30 11:25:45]

yeah I was confused as well. Apparently "enum" used uppercase, while "enum
class" use the k prefix...

+
+enum class IndexFilter { kIncludeIndices, kSkipIndices };
+
 /**
  * Integrity level for objects.
  */
 enum class IntegrityLevel { kFrozen, kSealed };
 
 /**
  * A JavaScript object (ECMA-262, 4.3.3)
  */
 class V8_EXPORT Object : public Value {
  public:
@@ skipping 127 matching lines @@
   Maybe<bool> DeletePrivate(Local<Context> context, Local<Private> key);
   MaybeLocal<Value> GetPrivate(Local<Context> context, Local<Private> key);
 
   /**
    * Returns an array containing the names of the enumerable properties
    * of this object, including properties from prototype objects.  The
    * array returned by this method contains the same values as would
    * be enumerated by a for-in statement over this object.
    */
   V8_DEPRECATE_SOON("Use maybe version", Local<Array> GetPropertyNames());
   V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetPropertyNames(

[Yang, 2016/05/30 09:25:28]

Why don't we just extend this with default args?

[Camillo Bruni, 2016/05/30 11:25:45]

Just followed the rest of the api here...

       Local<Context> context);
+  V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetPropertyNames(
+      Local<Context> context, KeyCollectionMode mode,
+      PropertyFilter property_filter, IndexFilter index_filter);
 
   /**
    * This function has the same functionality as GetPropertyNames but
    * the returned array doesn't contain the names of properties from
    * prototype objects.
    */
   V8_DEPRECATE_SOON("Use maybe version", Local<Array> GetOwnPropertyNames());
   V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetOwnPropertyNames(
       Local<Context> context);
 
@@ skipping 5985 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // INCLUDE_V8_H_