[sql] Use recover virtual table in sql::Recovery.

sql/connection_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/logging.h"
 #include "sql/connection.h"
 #include "sql/meta_table.h"
@@ skipping 407 matching lines @@
 }
 
 // Verify that Raze() can handle an empty file.  SQLite should treat
 // this as an empty database.
 TEST_F(SQLConnectionTest, RazeEmptyDB) {
   const char* kCreateSql = "CREATE TABLE foo (id INTEGER PRIMARY KEY, value)";
   ASSERT_TRUE(db().Execute(kCreateSql));
   db().Close();
 
   {
-    file_util::ScopedFILE file(file_util::OpenFile(db_path(), "r+"));
+    file_util::ScopedFILE file(file_util::OpenFile(db_path(), "rb+"));

[Scott Hess - ex-Googler, 2013/07/23 22:32:05]

I had a case in SQLRecoveryTest where reading a block and re-writing it didn't
work, because the first byte of a table page is 0x0D (CR).  Seemed reasonable to
make sure all of this code was using binary.

     ASSERT_TRUE(file.get() != NULL);
     ASSERT_EQ(0, fseek(file.get(), 0, SEEK_SET));
     ASSERT_TRUE(file_util::TruncateFile(file.get()));
   }
 
   ASSERT_TRUE(db().Open(db_path()));
   ASSERT_TRUE(db().Raze());
   EXPECT_EQ(0, SqliteMasterCount(&db()));
 }
 
 // Verify that Raze() can handle a file of junk.
 TEST_F(SQLConnectionTest, RazeNOTADB) {
   db().Close();
   sql::Connection::Delete(db_path());
   ASSERT_FALSE(base::PathExists(db_path()));
 
   {
-    file_util::ScopedFILE file(file_util::OpenFile(db_path(), "w"));
+    file_util::ScopedFILE file(file_util::OpenFile(db_path(), "wb"));
     ASSERT_TRUE(file.get() != NULL);
 
     const char* kJunk = "This is the hour of our discontent.";
     fputs(kJunk, file.get());
   }
   ASSERT_TRUE(base::PathExists(db_path()));
 
   // SQLite will successfully open the handle, but will fail with
   // SQLITE_IOERR_SHORT_READ on pragma statemenets which read the
   // header.
@@ skipping 12 matching lines @@
 }
 
 // Verify that Raze() can handle a database overwritten with garbage.
 TEST_F(SQLConnectionTest, RazeNOTADB2) {
   const char* kCreateSql = "CREATE TABLE foo (id INTEGER PRIMARY KEY, value)";
   ASSERT_TRUE(db().Execute(kCreateSql));
   ASSERT_EQ(1, SqliteMasterCount(&db()));
   db().Close();
 
   {
-    file_util::ScopedFILE file(file_util::OpenFile(db_path(), "r+"));
+    file_util::ScopedFILE file(file_util::OpenFile(db_path(), "rb+"));
     ASSERT_TRUE(file.get() != NULL);
     ASSERT_EQ(0, fseek(file.get(), 0, SEEK_SET));
 
     const char* kJunk = "This is the hour of our discontent.";
     fputs(kJunk, file.get());
   }
 
   // SQLite will successfully open the handle, but will fail with
   // SQLITE_NOTADB on pragma statemenets which attempt to read the
   // corrupted header.
@@ skipping 29 matching lines @@
   int page_size = 0;
   {
     sql::Statement s(db().GetUniqueStatement("PRAGMA page_size"));
     ASSERT_TRUE(s.Step());
     page_size = s.ColumnInt(0);
   }
   db().Close();
 
   // Trim a single page from the end of the file.
   {
-    file_util::ScopedFILE file(file_util::OpenFile(db_path(), "r+"));
+    file_util::ScopedFILE file(file_util::OpenFile(db_path(), "rb+"));
     ASSERT_TRUE(file.get() != NULL);
     ASSERT_EQ(0, fseek(file.get(), -page_size, SEEK_END));
     ASSERT_TRUE(file_util::TruncateFile(file.get()));
   }
 
   // Open() will succeed, even though the PRAGMA calls within will
   // fail with SQLITE_CORRUPT, as will this PRAGMA.
   {
     sql::ScopedErrorIgnorer ignore_errors;
     ignore_errors.IgnoreError(SQLITE_CORRUPT);
@@ skipping 296 matching lines @@
   }
 
   // Detach succeeds outside of a transaction.
   db().RollbackTransaction();
   EXPECT_TRUE(db().DetachDatabase(kAttachmentPoint));
 
   EXPECT_FALSE(db().IsSQLValid("SELECT count(*) from other.bar"));
 }
 
 }  // namespace