Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2002163002: Resynthesize exports lazily. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resynthesize exports lazily. This and the previous import changes made DDC about 18% faster, down from 1100 ms to 900 ms. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/635dc5fabf76e0c03827df323900ab9f670b8c05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -71 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 11 chunks +182 lines, -25 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 5 chunks +15 lines, -43 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 7 months ago (2016-05-23 17:58:53 UTC) #1
Paul Berry
lgtm
4 years, 7 months ago (2016-05-23 18:04:03 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 635dc5fabf76e0c03827df323900ab9f670b8c05 (presubmit successful).
4 years, 7 months ago (2016-05-23 18:05:34 UTC) #4
Cutch
On 2016/05/23 18:05:34, scheglov wrote: > Committed patchset #1 (id:1) manually as > 635dc5fabf76e0c03827df323900ab9f670b8c05 (presubmit ...
4 years, 7 months ago (2016-05-23 18:28:42 UTC) #5
scheglov
4 years, 7 months ago (2016-05-23 21:50:03 UTC) #6
Message was sent while issue was closed.
On 2016/05/23 18:28:42, Cutch wrote:
> On 2016/05/23 18:05:34, scheglov wrote:
> > Committed patchset #1 (id:1) manually as
> > 635dc5fabf76e0c03827df323900ab9f670b8c05 (presubmit successful).
> 
> I keep seeing CLs fly by with "speed up by x%". Where are these performance
> increases tracked?

These are performance numbers for DDC compilation of a big internal test case.
I'm not aware of a document where these changes are tracked.

Powered by Google App Engine
This is Rietveld 408576698