Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2002153008: recipe_tryjob: Actually fail on bad tests. (Closed)

Created:
4 years, 7 months ago by martiniss
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M scripts/slave/recipe_modules/recipe_tryjob/api.py View 1 chunk +15 lines, -19 lines 0 comments Download
M scripts/slave/recipes/infra/recipe_roll_tryjob.expected/three_patches_fail_not_ok.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
martiniss
PTAL Turns out that, while it correctly failed in the tests, it didn't fail on ...
4 years, 7 months ago (2016-05-25 23:47:38 UTC) #2
Paweł Hajdan Jr.
LGTM
4 years, 7 months ago (2016-05-26 18:01:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002153008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002153008/1
4 years, 7 months ago (2016-05-26 18:14:51 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:19:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/e88df6ed14c04d04314f...

Powered by Google App Engine
This is Rietveld 408576698