Issue 200213003: Handlification of ArrayConstructorCommon().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200213003: Handlification of ArrayConstructorCommon(). (Closed)

Created:
6 years, 9 months ago by Igor Sheludko

Modified:
6 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlification of ArrayConstructorCommon(). R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20001

Patch Set 2 : Addressing review comments. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -34 lines)			Patch
M	src/elements.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/elements.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/factory.h	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download
M	src/factory.cc	View	1	2 chunks	+22 lines, -4 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	4 chunks	+23 lines, -27 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with one comment. https://codereview.chromium.org/200213003/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/200213003/diff/1/src/factory.cc#newcode1442 src/factory.cc:1442: void Factory::AllocateJSArrayStorage(Handle<JSArray> array, If a ...

6 years, 9 months ago (2014-03-17 14:13:04 UTC) #2

Igor Sheludko

6 years, 9 months ago (2014-03-17 15:01:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20001 (presubmit successful).

Expand Messages | Collapse Messages

Issue 200213003: Handlification of ArrayConstructorCommon(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressing review comments. #

Messages