Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2002073003: Added missing include to profile_helper.h (Closed)

Created:
4 years, 7 months ago by ckulakowski
Modified:
4 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added missing include to profile_helper.h profile_helper.h uses ProfileMetrics::ProfileDelete defined in profile_metrics.h so it should be included. Lack of this include causes compilation error in our product. BUG= Committed: https://crrev.com/757fd0a4deb9f52ac8082a1f0741a9bc4e8ef438 Cr-Commit-Position: refs/heads/master@{#395573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/webui/profile_helper.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ckulakowski
4 years, 7 months ago (2016-05-23 13:59:18 UTC) #3
Bernhard Bauer
lgtm
4 years, 7 months ago (2016-05-24 10:40:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002073003/1
4 years, 7 months ago (2016-05-24 10:48:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 11:55:23 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 11:57:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/757fd0a4deb9f52ac8082a1f0741a9bc4e8ef438
Cr-Commit-Position: refs/heads/master@{#395573}

Powered by Google App Engine
This is Rietveld 408576698