[net/auth] Disable use of channel bindings on Posix.

[net/auth] Disable use of channel bindings on Posix.

We ran into interoperability issues on Mac OS X clients and MIT Kerberos
servers. (See bug for details). Out of an abundance of caution, we are
reverting to pre M51 behavior for Posix platforms.

R=rsleevi@chromium.org
BUG=611728
Committed: https://crrev.com/ccb5d4fc7a7e1045bd11fa7710879d4a6df850ed
Cr-Commit-Position: refs/heads/master@{#395675}

[asanka, 2016-05-24 18:23:04]

asanka@chromium.org changed reviewers:
+ mmenke@chromium.org

[asanka, 2016-05-24 18:25:28]

+mmenke: rsleevi is in an inconvenient time zone today. Would you mind taking a
look? I built a test binary and am asking the reporter to verify.

For details on why this is necessary, see
https://bugs.chromium.org/p/chromium/issues/detail?id=611728#c20

[mmenke, 2016-05-24 19:14:00]

On 2016/05/24 18:25:28, asanka wrote:
> +mmenke: rsleevi is in an inconvenient time zone today. Would you mind taking
a
> look? I built a test binary and am asking the reporter to verify.
> 
> For details on why this is necessary, see
> https://bugs.chromium.org/p/chromium/issues/detail?id=611728#c20

LGTM - looks like a safe return to the previous behavior in this method.  I'm
not sufficiently familiar with this code to whether or not there are any
potentially problematic interactions with any other changes in
https://codereview.chromium.org/1408433006 that this does not revert, or whether
any changes since then may have issues with this.  If I were to try to do that,
you certainly wouldn't be landing this in time for the next stable release.  :)

[asanka, 2016-05-24 19:17:45]

The CQ bit was checked by asanka@chromium.org

[commit-bot: I haz the power, 2016-05-24 19:18:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002063005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002063005/1

[asanka, 2016-05-24 19:19:30]

On 2016/05/24 at 19:14:00, mmenke wrote:
> On 2016/05/24 18:25:28, asanka wrote:
> > +mmenke: rsleevi is in an inconvenient time zone today. Would you mind
taking a
> > look? I built a test binary and am asking the reporter to verify.
> > 
> > For details on why this is necessary, see
> > https://bugs.chromium.org/p/chromium/issues/detail?id=611728#c20
> 
> LGTM - looks like a safe return to the previous behavior in this method.  I'm
not sufficiently familiar with this code to whether or not there are any
potentially problematic interactions with any other changes in
https://codereview.chromium.org/1408433006 that this does not revert, or whether
any changes since then may have issues with this.  If I were to try to do that,
you certainly wouldn't be landing this in time for the next stable release.  :)

Thanks! I've made the smallest change that would deliver the behavior we want
since we want a clean merge. It's not a clean removal of channel bindings on
Posix, but too many changes and we are going to have a bad time.

Much of the remaining changes are those that are required for channel bindings
on Windows.

[commit-bot: I haz the power, 2016-05-24 19:30:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-24 19:32:52]

Description was changed from

==========
[net/auth] Disable use of channel bindings on Posix.

We ran into interoperability issues on Mac OS X clients and MIT Kerberos
servers. (See bug for details). Out of an abundance of caution, we are
reverting to pre M51 behavior for Posix platforms.

R=rsleevi@chromium.org
BUG=611728
==========

to

==========
[net/auth] Disable use of channel bindings on Posix.

We ran into interoperability issues on Mac OS X clients and MIT Kerberos
servers. (See bug for details). Out of an abundance of caution, we are
reverting to pre M51 behavior for Posix platforms.

R=rsleevi@chromium.org
BUG=611728

Committed: https://crrev.com/ccb5d4fc7a7e1045bd11fa7710879d4a6df850ed
Cr-Commit-Position: refs/heads/master@{#395675}
==========

[commit-bot: I haz the power, 2016-05-24 19:32:53]

Patchset 1 (id:??) landed as
https://crrev.com/ccb5d4fc7a7e1045bd11fa7710879d4a6df850ed
Cr-Commit-Position: refs/heads/master@{#395675}