[css-grid] Disallow repeat() in grid-template shorthand

[css-grid] Disallow repeat() in grid-template shorthand

As discussed on www-style, "repeat()" notation shouldn't be allowed
in the ASCII branch of the grid-template shorthand.
https://lists.w3.org/Archives/Public/www-style/2016May/0193.html

The patch adds a boolean in consumeGridTrackList()
to invalidate "repeat()" when parsing grid-template shorthand.

BUG=614314
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html

Committed: https://crrev.com/9a6a6f02b663a4066fe26d9d57809faeaaa8ee6a
Cr-Commit-Position: refs/heads/master@{#402429}

[Manuel Rego, 2016-05-24 10:37:02]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, rob.buis@samsung.com, svillar@igalia.com,
timloh@chromium.org

[Manuel Rego, 2016-05-24 10:37:03]

I'll wait until the spec syntax is updated before landing,
but as I've the patch ready I preferred to upload it. :-)

[rwlbuis, 2016-05-24 15:22:29]

lgtm, thanks for addressing these TODOs!

I'd also wait for timloh to have a look since IIRC he requested the TODO in the
first place :)

[svillar, 2016-05-24 19:18:13]

lgtm too.

BTW I'd say "Forbid repeat()" or "Disallow repeat()" but not "Avoid" since we
don't want to skip it but veto it.

[Timothy Loh, 2016-05-25 00:59:39]

lgtm

[Manuel Rego, 2016-05-25 07:10:27]

Description was changed from

==========
[css-grid] Avoid repeat() in grid-template shorthand

As discussed on www-style, "repeat()" notation shouldn't be allowed
in the ASCII branch of the grid-template shorthand.
https://lists.w3.org/Archives/Public/www-style/2016May/0193.html

The patch adds a boolean in consumeGridTrackList()
to invalidate "repeat()" when parsing grid-template shorthand.

BUG=614314
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html
==========

to

==========
[css-grid] Disallow repeat() in grid-template shorthand

As discussed on www-style, "repeat()" notation shouldn't be allowed
in the ASCII branch of the grid-template shorthand.
https://lists.w3.org/Archives/Public/www-style/2016May/0193.html

The patch adds a boolean in consumeGridTrackList()
to invalidate "repeat()" when parsing grid-template shorthand.

BUG=614314
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html
==========

[Manuel Rego, 2016-06-28 07:03:48]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2016-06-28 07:03:48]

The patchset sent to the CQ was uploaded after l-g-t-m from svillar@igalia.com,
timloh@chromium.org, rob.buis@samsung.com
Link to the patchset: https://codereview.chromium.org/2002063004/#ps20001
(title: "Rebased patch for landing")

[commit-bot: I haz the power, 2016-06-28 07:03:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Manuel Rego, 2016-06-28 07:04:02]

The spec has been finally updated so we can land this:
https://github.com/w3c/csswg-drafts/commit/8688b98

[commit-bot: I haz the power, 2016-06-28 09:08:15]

Description was changed from

==========
[css-grid] Disallow repeat() in grid-template shorthand

As discussed on www-style, "repeat()" notation shouldn't be allowed
in the ASCII branch of the grid-template shorthand.
https://lists.w3.org/Archives/Public/www-style/2016May/0193.html

The patch adds a boolean in consumeGridTrackList()
to invalidate "repeat()" when parsing grid-template shorthand.

BUG=614314
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html
==========

to

==========
[css-grid] Disallow repeat() in grid-template shorthand

As discussed on www-style, "repeat()" notation shouldn't be allowed
in the ASCII branch of the grid-template shorthand.
https://lists.w3.org/Archives/Public/www-style/2016May/0193.html

The patch adds a boolean in consumeGridTrackList()
to invalidate "repeat()" when parsing grid-template shorthand.

BUG=614314
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html
==========

[commit-bot: I haz the power, 2016-06-28 09:08:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-28 09:10:32]

Description was changed from

==========
[css-grid] Disallow repeat() in grid-template shorthand

As discussed on www-style, "repeat()" notation shouldn't be allowed
in the ASCII branch of the grid-template shorthand.
https://lists.w3.org/Archives/Public/www-style/2016May/0193.html

The patch adds a boolean in consumeGridTrackList()
to invalidate "repeat()" when parsing grid-template shorthand.

BUG=614314
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html
==========

to

==========
[css-grid] Disallow repeat() in grid-template shorthand

As discussed on www-style, "repeat()" notation shouldn't be allowed
in the ASCII branch of the grid-template shorthand.
https://lists.w3.org/Archives/Public/www-style/2016May/0193.html

The patch adds a boolean in consumeGridTrackList()
to invalidate "repeat()" when parsing grid-template shorthand.

BUG=614314
TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html

Committed: https://crrev.com/9a6a6f02b663a4066fe26d9d57809faeaaa8ee6a
Cr-Commit-Position: refs/heads/master@{#402429}
==========

[commit-bot: I haz the power, 2016-06-28 09:10:33]

Patchset 2 (id:??) landed as
https://crrev.com/9a6a6f02b663a4066fe26d9d57809faeaaa8ee6a
Cr-Commit-Position: refs/heads/master@{#402429}