Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2002063004: [css-grid] Disallow repeat() in grid-template shorthand (Closed)

Created:
4 years, 6 months ago by Manuel Rego
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jfernandez, svillar, blink-reviews-css, Manuel Rego, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Disallow repeat() in grid-template shorthand As discussed on www-style, "repeat()" notation shouldn't be allowed in the ASCII branch of the grid-template shorthand. https://lists.w3.org/Archives/Public/www-style/2016May/0193.html The patch adds a boolean in consumeGridTrackList() to invalidate "repeat()" when parsing grid-template shorthand. BUG=614314 TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html Committed: https://crrev.com/9a6a6f02b663a4066fe26d9d57809faeaaa8ee6a Cr-Commit-Position: refs/heads/master@{#402429}

Patch Set 1 #

Patch Set 2 : Rebased patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html View 1 6 chunks +22 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt View 1 3 chunks +20 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Manuel Rego
I'll wait until the spec syntax is updated before landing, but as I've the patch ...
4 years, 6 months ago (2016-05-24 10:37:03 UTC) #2
rwlbuis
lgtm, thanks for addressing these TODOs! I'd also wait for timloh to have a look ...
4 years, 6 months ago (2016-05-24 15:22:29 UTC) #3
svillar
lgtm too. BTW I'd say "Forbid repeat()" or "Disallow repeat()" but not "Avoid" since we ...
4 years, 6 months ago (2016-05-24 19:18:13 UTC) #4
Timothy Loh
lgtm
4 years, 6 months ago (2016-05-25 00:59:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2002063004/20001
4 years, 5 months ago (2016-06-28 07:03:56 UTC) #9
Manuel Rego
The spec has been finally updated so we can land this: https://github.com/w3c/csswg-drafts/commit/8688b98
4 years, 5 months ago (2016-06-28 07:04:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 09:08:16 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 09:10:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a6a6f02b663a4066fe26d9d57809faeaaa8ee6a
Cr-Commit-Position: refs/heads/master@{#402429}

Powered by Google App Engine
This is Rietveld 408576698