Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2002063002: Make SpeechRecognizerApplicationDelegate class public. (Closed)

Created:
4 years, 7 months ago by nellyv
Modified:
4 years, 7 months ago
Reviewers:
nelly, viettrungluu, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make SpeechRecognizerApplicationDelegate class public. This will allow using the corresponding library in manganese. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/59706589e274be6807cf4d106a9307dfa6764a86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M services/speech_recognizer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/speech_recognizer/src/org/chromium/mojo/speech_recognizer/SpeechRecognizerApplicationDelegate.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
nelly
Ptal.
4 years, 7 months ago (2016-05-23 12:33:06 UTC) #2
qsr
lgtm
4 years, 7 months ago (2016-05-23 12:34:11 UTC) #3
nellyv
4 years, 7 months ago (2016-05-23 12:35:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
59706589e274be6807cf4d106a9307dfa6764a86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698