Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2002033002: Extends README.md to mention indirect use. (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
Reviewers:
sigurdm
CC:
eernst+reviews_google.com, reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/reflectable.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extends README.md to mention indirect use. This CL adds a paragraph to README.md explaining that even indirect clients of reflectable need to specify the reflectable transformer in their `pubspec.yaml`. This is not necessary for clients who want to run in pre-transformed mode all the time, but presumably such clients do not exist and hence we won't help them. In general, indirect usage involves an intermediate library L, and "specify the reflectable transformer" should be part of the documentation for L; hence, this CL also adds a sentence directed at writers of such intermediate libraries. Adresses issue 84. R=sigurdm@google.com Committed: https://github.com/dart-lang/reflectable/commit/b3f302ba3249f14177ad7b26d26d75915aab6980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M reflectable/README.md View 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
Doc fix coming from issue 84.
4 years, 7 months ago (2016-05-23 11:37:11 UTC) #2
sigurdm
LGTM!
4 years, 7 months ago (2016-05-23 11:51:42 UTC) #3
eernst
4 years, 7 months ago (2016-05-23 12:28:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b3f302ba3249f14177ad7b26d26d75915aab6980 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698