Generate CSP violation reports for 'block-all-mixed-content'

Generate CSP violation reports for 'block-all-mixed-content'

As of https://github.com/w3c/webappsec-mixed-content/commit/e9c559c6672e3219a0c1f6f4f7c5c187f3d51377,
'block-all-mixed-content' generates violation reports. This patch implements that functionality.

BUG=613956
Committed: https://crrev.com/8b74280c04ed4eeee89c9da257c4cee86afdfd1d
Cr-Commit-Position: refs/heads/master@{#396155}

[Mike West, 2016-05-23 10:15:37]

mkwst@chromium.org changed reviewers:
+ estark@chromium.org, jww@chromium.org

[Mike West, 2016-05-23 10:15:38]

Emily, Joel: if you have some time this week, I have ~2 CSP reporting patches
for y'all. I'm on vacation, and not actually in the office, so no rush on
reviewing. :)

[Mike West, 2016-05-25 19:12:21]

Ping2? :)

[jww, 2016-05-25 23:02:02]

On 2016/05/25 19:12:21, Mike West (OOO until 30th) wrote:
> Ping2? :)

No rush because you're on vacation, eh? ;-) I'll take a look in a few.

[jww, 2016-05-26 00:30:34]

lgtm, with one test suggestion.

https://codereview.chromium.org/2002003002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/security/mixedContent/strict-mode-image-blocked.https.html
(right):

https://codereview.chromium.org/2002003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/security/mixedContent/strict-mode-image-blocked.https.html:37:
}, "Mixed images generate CSP violation reports in the presence of
'block-all-mixed-content'.");
Would it be worth add a second test file for a report-only variant of that,
given that we've had some report-only issues in the past?

[Mike West, 2016-05-26 05:26:07]

Patchset #2 (id:20001) has been deleted

[Mike West, 2016-05-26 10:48:26]

On 2016/05/25 at 23:02:02, jww wrote:
> On 2016/05/25 19:12:21, Mike West (OOO until 30th) wrote:
> > Ping2? :)
> 
> No rush because you're on vacation, eh? ;-) I'll take a look in a few.

1. It came up in the meeting, so, you know... :)

2. I'm super bad at vacation.

3. I added tests!

[Mike West, 2016-05-26 10:48:45]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2016-05-26 10:48:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jww@chromium.org
Link to the patchset: https://codereview.chromium.org/2002003002/#ps60001
(title: "PHP")

[commit-bot: I haz the power, 2016-05-26 10:48:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002003002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002003002/60001

[commit-bot: I haz the power, 2016-05-26 10:52:32]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-26 10:54:23]

Description was changed from

==========
Generate CSP violation reports for 'block-all-mixed-content'

As of
https://github.com/w3c/webappsec-mixed-content/commit/e9c559c6672e3219a0c1f6f...,
'block-all-mixed-content' generates violation reports. This patch implements
that functionality.

BUG=613956
==========

to

==========
Generate CSP violation reports for 'block-all-mixed-content'

As of
https://github.com/w3c/webappsec-mixed-content/commit/e9c559c6672e3219a0c1f6f...,
'block-all-mixed-content' generates violation reports. This patch implements
that functionality.

BUG=613956

Committed: https://crrev.com/8b74280c04ed4eeee89c9da257c4cee86afdfd1d
Cr-Commit-Position: refs/heads/master@{#396155}
==========

[commit-bot: I haz the power, 2016-05-26 10:54:24]

Patchset 3 (id:??) landed as
https://crrev.com/8b74280c04ed4eeee89c9da257c4cee86afdfd1d
Cr-Commit-Position: refs/heads/master@{#396155}