Make imports resynthesizing completely lazy.

Make imports resynthesizing completely lazy.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/caac40c875b02be5582b430e089349eaf2e347d3

[Paul Berry, 2016-05-23 15:43:52]

lgtm

https://codereview.chromium.org/2001903002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2001903002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:3617: return _hiddenNames ??
StringUtilities.EMPTY_ARRAY;
Nit: personally, I'd use `const <String>[]` here.  It's less typing and it
doesn't require the reader to do a cross reference to know what's going on.

[scheglov, 2016-05-23 15:48:42]

https://codereview.chromium.org/2001903002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2001903002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:3617: return _hiddenNames ??
StringUtilities.EMPTY_ARRAY;
On 2016/05/23 15:43:52, Paul Berry wrote:
> Nit: personally, I'd use `const <String>[]` here.  It's less typing and it
> doesn't require the reader to do a cross reference to know what's going on.

Done.

[scheglov, 2016-05-23 15:56:52]

Description was changed from

==========
Make imports resynthesizing completely lazy.

R=paulberry@google.com
BUG=
==========

to

==========
Make imports resynthesizing completely lazy.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/caac40c875b02be5582b430e089349eaf2e347d3
==========

[scheglov, 2016-05-23 15:56:53]

Committed patchset #1 (id:1) manually as
caac40c875b02be5582b430e089349eaf2e347d3 (presubmit successful).