Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2001853002: Re-enable 32-bit linux for nacl sdk, disable for mac tests. (Closed)

Created:
4 years, 7 months ago by bradnelson
Modified:
4 years, 7 months ago
Reviewers:
bradn, binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable 32-bit linux for nacl sdk, disable for mac tests. Just realized the prior change to drop linux32 will regress webports. Also, it's nice to have an os that can run it all arches. Disabling 32-bit tests and enabling 64-bit ones for mac. BUG=None TEST=None TBR=binji@chromium.org Committed: https://crrev.com/eb8ae90a115a757b1d7e21539f50eead8511cc95 Cr-Commit-Position: refs/heads/master@{#395255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/test_sdk.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bradn
4 years, 7 months ago (2016-05-20 22:07:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001853002/1
4 years, 7 months ago (2016-05-20 22:07:54 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233311)
4 years, 7 months ago (2016-05-21 00:35:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001853002/1
4 years, 7 months ago (2016-05-21 08:33:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-21 09:02:21 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-21 09:04:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb8ae90a115a757b1d7e21539f50eead8511cc95
Cr-Commit-Position: refs/heads/master@{#395255}

Powered by Google App Engine
This is Rietveld 408576698