chrome/browser/ui/views/toolbar/toolbar_action_view.cc - Issue 2001843002: Use ink drop hover for focus states on toolbar buttons and location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 2001843002: Use ink drop hover for focus states on toolbar buttons and location (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: layout Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view.h ('k') | chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

index 8b006f04a2b8d2fa52dcd7a141d1134609259cef..bfb6bf7eb66e3e8c4d657f70ee4238b038b540a7 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

@@ -61,9 +61,9 @@ ToolbarActionView::ToolbarActionView(

called_register_command_(false),

wants_to_run_(false),

menu_(nullptr),

- ink_drop_delegate_(new views::ButtonInkDropDelegate(this, this)),

weak_factory_(this) {

- set_ink_drop_delegate(ink_drop_delegate_.get());

+ set_ink_drop_delegate(

+ base::WrapUnique(new views::ButtonInkDropDelegate(this, this)));

set_has_ink_drop_action_on_click(true);

set_id(VIEW_ID_BROWSER_ACTION);

view_controller_->SetDelegate(this);