chrome/browser/ui/views/toolbar/toolbar_action_view.h - Issue 2001843002: Use ink drop hover for focus states on toolbar buttons and location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.h

Issue 2001843002: Use ink drop hover for focus states on toolbar buttons and location (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review feedback and add test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/app_menu_button.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_action_view.cc » ('j') | ui/views/animation/ink_drop_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/toolbar_action_view.h

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.h b/chrome/browser/ui/views/toolbar/toolbar_action_view.h

index 5d7a7454191ba7fc2eba06baa29c8335376a2879..5455aa021b1d0e9201496f1d1e622344ed8b4bb6 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.h

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.h

@@ -164,8 +164,6 @@ class ToolbarActionView : public views::MenuButton,

// The time the popup was last closed.

base::TimeTicks popup_closed_time_;

- std::unique_ptr<views::InkDropDelegate> ink_drop_delegate_;

base::WeakPtrFactory<ToolbarActionView> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(ToolbarActionView);