chrome/browser/ui/views/location_bar/bubble_icon_view.h - Issue 2001843002: Use ink drop hover for focus states on toolbar buttons and location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.h

Issue 2001843002: Use ink drop hover for focus states on toolbar buttons and location (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: format Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/download/download_item_view_md.cc ('k') | chrome/browser/ui/views/location_bar/bubble_icon_view.cc » ('j') | ui/views/animation/ink_drop_host_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/bubble_icon_view.h

diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.h b/chrome/browser/ui/views/location_bar/bubble_icon_view.h

index 53538cfce409a36270bd74ea3a6d764512011eb2..b5d9585f93bc2f705a139466aa231ab52775f54f 100644

--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.h

+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.h

@@ -74,6 +74,7 @@ class BubbleIconView : public views::InkDropHostView,

void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;

std::unique_ptr<views::InkDropHover> CreateInkDropHover() const override;

SkColor GetInkDropBaseColor() const override;

+ bool ShouldShowInkDropForFocus() const override;

// ui::EventHandler:

void OnGestureEvent(ui::GestureEvent* event) override;