Use ink drop hover for focus states on toolbar buttons and location

ui/views/animation/ink_drop_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/animation/ink_drop_impl.h"
 
 #include "base/auto_reset.h"
 #include "base/timer/timer.h"
 #include "ui/compositor/layer.h"
 #include "ui/views/animation/ink_drop_host.h"
@@ skipping 92 matching lines @@
 void InkDropImpl::SetHovered(bool is_hovered) {
   is_hovered_ = is_hovered;
   SetHoveredInternal(is_hovered,
                      is_hovered ? base::TimeDelta::FromMilliseconds(
                                       kHoverFadeInFromUserInputDurationInMs)
                                 : base::TimeDelta::FromMilliseconds(
                                       kHoverFadeOutFromUserInputDurationInMs),
                      false);
 }
 
+void InkDropImpl::SnapToHovered(bool is_hovered) {

[Evan Stade, 2016/05/24 18:47:18]

I specifically avoided turning |is_hovered_| into a counter, with the outcome
that if you mouse over a button while it's focused, then unhover, the focus
shadow goes away. I actually believe this makes more sense because the focus
effect is supposed to be for people using the keyboard. Hence,
request_focus_on_press_ for buttons is almost always false. If you use the
keyboard, then switch to the mouse, it makes sense to stop showing the hover
effect. (Honestly I think this is rare enough that it doesn't matter much one
way or another.)

+  is_hovered_ = is_hovered;
+  SetHoveredInternal(is_hovered, base::TimeDelta(), false);
+}
+
 void InkDropImpl::DestroyHiddenTargetedAnimations() {
   if (ink_drop_ripple_ &&
       (ink_drop_ripple_->target_ink_drop_state() == InkDropState::HIDDEN ||
        ShouldAnimateToHidden(ink_drop_ripple_->target_ink_drop_state()))) {
     DestroyInkDropRipple();
   }
 }
 
 void InkDropImpl::CreateInkDropRipple() {
   DestroyInkDropRipple();
@@ skipping 121 matching lines @@
 }
 
 void InkDropImpl::HoverAfterRippleTimerFired() {
   SetHoveredInternal(true, base::TimeDelta::FromMilliseconds(
                                kHoverFadeInAfterRippleDurationInMs),
                      true);
   hover_after_ripple_timer_.reset();
 }
 
 }  // namespace views