Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2001823004: style: Rename the EBoxPack enum values to be prefixed. (Closed)

Created:
4 years, 7 months ago by Deokjin Kim
Modified:
4 years, 7 months ago
Reviewers:
danakj, Timothy Loh, dcheng
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

style: Rename the EBoxPack enum values to be prefixed. BUG=584543 Committed: https://crrev.com/48289b58efaaf58bf1b9d71ba190cd9ad9eb65be Cr-Commit-Position: refs/heads/master@{#395307}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
Deokjin Kim
PTAL. Thank you in advance.
4 years, 7 months ago (2016-05-21 14:25:01 UTC) #3
danakj
LGTM
4 years, 7 months ago (2016-05-23 02:35:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001823004/1
4 years, 7 months ago (2016-05-23 02:39:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/187955)
4 years, 7 months ago (2016-05-23 02:45:42 UTC) #8
dcheng
lgtm
4 years, 7 months ago (2016-05-23 03:55:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001823004/1
4 years, 7 months ago (2016-05-23 03:56:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233551)
4 years, 7 months ago (2016-05-23 05:17:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001823004/1
4 years, 7 months ago (2016-05-23 05:33:03 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233623)
4 years, 7 months ago (2016-05-23 08:17:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001823004/1
4 years, 7 months ago (2016-05-23 10:25:54 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 12:50:10 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 12:51:24 UTC) #23
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/48289b58efaaf58bf1b9d71ba190cd9ad9eb65be
Cr-Commit-Position: refs/heads/master@{#395307}

Powered by Google App Engine
This is Rietveld 408576698