base/logging.cc - Issue 2001783002: base: Support using (D)CHECK on scoped enums.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.cc

Issue 2001783002: base: Support using (D)CHECK on scoped enums. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use CR_GLIBCXX_4_7_0 macro, since I bothered to define it Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging.cc

diff --git a/base/logging.cc b/base/logging.cc

index 4390d8cda3069f2c63f7dbd83b97765658773e5c..98cecd094fd84e7312c9a3e9998dfb44cfd05925 100644

--- a/base/logging.cc

+++ b/base/logging.cc

@@ -454,8 +454,7 @@ template std::string* MakeCheckOpString<unsigned int, unsigned long>(

template std::string* MakeCheckOpString<std::string, std::string>(

const std::string&, const std::string&, const char* name);

-template <>

-void MakeCheckOpValueString(std::ostream* os, const std::nullptr_t& p) {

+void MakeCheckOpValueString(std::ostream* os, std::nullptr_t p) {

(*os) << "nullptr";

}