Use std::set to track uniqueness in xfa_script_layoutpseudomodel.cpp

xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/parser/xfa_script_layoutpseudomodel.h"
 
+#include <set>
+
+#include "third_party/base/stl_util.h"
 #include "xfa/fxfa/app/xfa_ffnotify.h"
 #include "xfa/fxfa/fm2js/xfa_fm2jsapi.h"
 #include "xfa/fxfa/parser/xfa_doclayout.h"
 #include "xfa/fxfa/parser/xfa_document.h"
 #include "xfa/fxfa/parser/xfa_document_layout_imp.h"
 #include "xfa/fxfa/parser/xfa_layout_appadapter.h"
 #include "xfa/fxfa/parser/xfa_localemgr.h"
 #include "xfa/fxfa/parser/xfa_object.h"
 #include "xfa/fxfa/parser/xfa_parser.h"
 #include "xfa/fxfa/parser/xfa_parser_imp.h"
@@ skipping 206 matching lines @@
   }
   if (wsType == FX_WSTRC(L"contentArea")) {
     for (CXFA_LayoutItem* pItem = pLayoutPage->m_pFirstChild; pItem;
          pItem = pItem->m_pNextSibling) {
       if (pItem->m_pFormNode->GetClassID() == XFA_ELEMENT_ContentArea) {
         retArray.Add(pItem->m_pFormNode);
       }
     }
     return;
   }
-  CFX_MapPtrToPtr formItems;
-  formItems.InitHashTable(256, TRUE);
+  std::set<CXFA_Node*> formItems;
   if (wsType.IsEmpty()) {
     if (CXFA_Node* pMasterPage = pLayoutPage->m_pFormNode) {
       retArray.Add(pMasterPage);
     }
     for (CXFA_LayoutItem* pItem = pLayoutPage->m_pFirstChild; pItem;
          pItem = pItem->m_pNextSibling) {
       if (pItem->m_pFormNode->GetClassID() == XFA_ELEMENT_ContentArea) {
         retArray.Add(pItem->m_pFormNode);
         if (!bOnPageArea) {
           CXFA_NodeIteratorTemplate<CXFA_ContentLayoutItem,
                                     CXFA_TraverseStrategy_ContentLayoutItem>
           iterator((CXFA_ContentLayoutItem*)pItem->m_pFirstChild);
           for (CXFA_ContentLayoutItem* pItemChild = iterator.GetCurrent();
                pItemChild; pItemChild = iterator.MoveToNext()) {
             if (!pItemChild->IsContentLayoutItem()) {
               continue;
             }
             XFA_ELEMENT eElementType = pItemChild->m_pFormNode->GetClassID();
             if (eElementType != XFA_ELEMENT_Field &&
                 eElementType != XFA_ELEMENT_Draw &&
                 eElementType != XFA_ELEMENT_Subform &&
                 eElementType != XFA_ELEMENT_Area) {
               continue;
             }
-            if (formItems.GetValueAt(pItemChild->m_pFormNode)) {
+            if (pdfium::ContainsValue(formItems, pItemChild->m_pFormNode))
               continue;
-            }
-            formItems.SetAt(pItemChild->m_pFormNode, this);
+
+            formItems.insert(pItemChild->m_pFormNode);
             retArray.Add(pItemChild->m_pFormNode);
           }
         }
       } else {
         if (bOnPageArea) {
           CXFA_NodeIteratorTemplate<CXFA_ContentLayoutItem,
                                     CXFA_TraverseStrategy_ContentLayoutItem>
           iterator((CXFA_ContentLayoutItem*)pItem);
           for (CXFA_ContentLayoutItem* pItemChild = iterator.GetCurrent();
                pItemChild; pItemChild = iterator.MoveToNext()) {
             if (!pItemChild->IsContentLayoutItem()) {
               continue;
             }
             XFA_ELEMENT eElementType = pItemChild->m_pFormNode->GetClassID();
             if (eElementType != XFA_ELEMENT_Field &&
                 eElementType != XFA_ELEMENT_Draw &&
                 eElementType != XFA_ELEMENT_Subform &&
                 eElementType != XFA_ELEMENT_Area) {
               continue;
             }
-            if (formItems.GetValueAt(pItemChild->m_pFormNode)) {
+            if (pdfium::ContainsValue(formItems, pItemChild->m_pFormNode))
               continue;
-            }
-            formItems.SetAt(pItemChild->m_pFormNode, this);
+            formItems.insert(pItemChild->m_pFormNode);
             retArray.Add(pItemChild->m_pFormNode);
           }
         }
       }
     }
     return;
   }
   XFA_ELEMENT eType = XFA_ELEMENT_UNKNOWN;
   if (wsType == FX_WSTRC(L"field")) {
     eType = XFA_ELEMENT_Field;
   } else if (wsType == FX_WSTRC(L"draw")) {
     eType = XFA_ELEMENT_Draw;
   } else if (wsType == FX_WSTRC(L"subform")) {
     eType = XFA_ELEMENT_Subform;
   } else if (wsType == FX_WSTRC(L"area")) {
     eType = XFA_ELEMENT_Area;
   }
   if (eType != XFA_ELEMENT_UNKNOWN) {
     for (CXFA_LayoutItem* pItem = pLayoutPage->m_pFirstChild; pItem;
          pItem = pItem->m_pNextSibling) {
       if (pItem->m_pFormNode->GetClassID() == XFA_ELEMENT_ContentArea) {
         if (!bOnPageArea) {
           CXFA_NodeIteratorTemplate<CXFA_ContentLayoutItem,
                                     CXFA_TraverseStrategy_ContentLayoutItem>
           iterator((CXFA_ContentLayoutItem*)pItem->m_pFirstChild);
           for (CXFA_ContentLayoutItem* pItemChild = iterator.GetCurrent();
                pItemChild; pItemChild = iterator.MoveToNext()) {
-            if (!pItemChild->IsContentLayoutItem()) {
+            if (!pItemChild->IsContentLayoutItem())
               continue;
-            }
-            if (pItemChild->m_pFormNode->GetClassID() != eType) {
+            if (pItemChild->m_pFormNode->GetClassID() != eType)
               continue;
-            }
-            if (formItems.GetValueAt(pItemChild->m_pFormNode)) {
+            if (pdfium::ContainsValue(formItems, pItemChild->m_pFormNode))
               continue;
-            }
-            formItems.SetAt(pItemChild->m_pFormNode, this);
+            formItems.insert(pItemChild->m_pFormNode);
             retArray.Add(pItemChild->m_pFormNode);
           }
         }
       } else {
         if (bOnPageArea) {
           CXFA_NodeIteratorTemplate<CXFA_ContentLayoutItem,
                                     CXFA_TraverseStrategy_ContentLayoutItem>
           iterator((CXFA_ContentLayoutItem*)pItem);
           for (CXFA_ContentLayoutItem* pItemChild = iterator.GetCurrent();
                pItemChild; pItemChild = iterator.MoveToNext()) {
-            if (!pItemChild->IsContentLayoutItem()) {
+            if (!pItemChild->IsContentLayoutItem())
               continue;
-            }
-            if (pItemChild->m_pFormNode->GetClassID() != eType) {
+            if (pItemChild->m_pFormNode->GetClassID() != eType)
               continue;
-            }
-            if (formItems.GetValueAt(pItemChild->m_pFormNode)) {
+            if (pdfium::ContainsValue(formItems, pItemChild->m_pFormNode))
               continue;
-            }
-            formItems.SetAt(pItemChild->m_pFormNode, this);
+            formItems.insert(pItemChild->m_pFormNode);
             retArray.Add(pItemChild->m_pFormNode);
           }
         }
       }
     }
     return;
   }
 }
 void CScript_LayoutPseudoModel::Script_LayoutPseudoModel_PageContent(
     CFXJSE_Arguments* pArguments) {
@@ skipping 192 matching lines @@
   CXFA_LayoutItem* pLayoutItem = pDocLayout->GetLayoutItem(pNode);
   if (!pLayoutItem) {
     FXJSE_Value_SetInteger(hValue, -1);
     return;
   }
   iPage = pLayoutItem->GetFirst()->GetPage()->GetPageIndex();
   if (hValue) {
     FXJSE_Value_SetInteger(hValue, bAbsPage ? iPage : iPage + 1);
   }
 }