Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2001713002: - Removed the kWatchedBit and the associated weak property handling (Closed)

Created:
4 years, 7 months ago by Ivan Posva
Modified:
4 years, 6 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Removed the kWatchedBit and the associated weak property handling code from the GCs. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/5295e99d276331880e9a26d434b817f065b9be3c

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove residual watched bit. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -240 lines) Patch
M runtime/vm/gc_marker.cc View 1 15 chunks +71 lines, -122 lines 1 comment Download
M runtime/vm/object.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 4 chunks +10 lines, -26 lines 1 comment Download
M runtime/vm/scavenger.h View 3 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/scavenger.cc View 1 15 chunks +87 lines, -83 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ivan Posva
https://codereview.chromium.org/2001713002/diff/1/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://codereview.chromium.org/2001713002/diff/1/runtime/vm/raw_object.h#newcode259 runtime/vm/raw_object.h:259: kTheBitFormerlyKnownAsTheWatchedBit = 0, I am planning to move the ...
4 years, 7 months ago (2016-05-20 18:13:35 UTC) #2
Ivan Posva
Updated to remove the bit... -Ivan
4 years, 7 months ago (2016-05-20 23:49:37 UTC) #3
siva
lgtm https://codereview.chromium.org/2001713002/diff/20001/runtime/vm/gc_marker.cc File runtime/vm/gc_marker.cc (right): https://codereview.chromium.org/2001713002/diff/20001/runtime/vm/gc_marker.cc#newcode285 runtime/vm/gc_marker.cc:285: WeakProperty::Clear(cur_weak); Maybe set next_ to 0 inside Clear ...
4 years, 7 months ago (2016-05-23 20:35:33 UTC) #4
Ivan Posva
Committed patchset #2 (id:20001) manually as 5295e99d276331880e9a26d434b817f065b9be3c (presubmit successful).
4 years, 6 months ago (2016-05-24 20:22:54 UTC) #6
rmacnak
4 years, 6 months ago (2016-05-24 20:58:42 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2001713002/diff/20001/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/2001713002/diff/20001/runtime/vm/raw_object.h...
runtime/vm/raw_object.h:265: kReservedTagSize = 3,
= 4

Powered by Google App Engine
This is Rietveld 408576698