Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2001573003:
💂 GN: Fix java_library() when supplied with a generated .java (Closed)
DescriptionGN: Fix java_library() when supplied with a generated .java
Currently, the deps of the internal targets are setup inccorrectly:
ERROR Input to target not generated by a dependency.
BUG=none
Committed: https://crrev.com/76d9b76939631c27efafd994fbebef6bdafb4696
Cr-Commit-Position: refs/heads/master@{#395113}
Patch Set 1 #
Messages
Total messages: 16 (8 generated)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001573003/1
Description was changed from
==========
GN: Fix java_library() when supplied with a generated .java
Currently, the deps of the internal targets are setup correctly:
ERROR Input to target not generated by a dependency.
BUG=none
==========
to
==========
GN: Fix java_library() when supplied with a generated .java
Currently, the deps of the internal targets are setup correctly:
ERROR Input to target not generated by a dependency.
BUG=none
==========
agrieve@chromium.org changed reviewers: + pkotwicz@chromium.org
On 2016/05/20 14:10:20, commit-bot: I haz the power wrote: > Dry run: CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/2001573003/1 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/2001573003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
GN: Fix java_library() when supplied with a generated .java
Currently, the deps of the internal targets are setup correctly:
ERROR Input to target not generated by a dependency.
BUG=none
==========
to
==========
GN: Fix java_library() when supplied with a generated .java
Currently, the deps of the internal targets are setup inccorrectly:
ERROR Input to target not generated by a dependency.
BUG=none
==========
LGTM Howver, I tried patching this CL and https://codereview.chromium.org/1975153003/ locally and the build fails
LGTM Howver, I tried patching this CL and https://codereview.chromium.org/1975153003/ locally and the build fails
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001573003/1
Message was sent while issue was closed.
Description was changed from
==========
GN: Fix java_library() when supplied with a generated .java
Currently, the deps of the internal targets are setup inccorrectly:
ERROR Input to target not generated by a dependency.
BUG=none
==========
to
==========
GN: Fix java_library() when supplied with a generated .java
Currently, the deps of the internal targets are setup inccorrectly:
ERROR Input to target not generated by a dependency.
BUG=none
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
GN: Fix java_library() when supplied with a generated .java
Currently, the deps of the internal targets are setup inccorrectly:
ERROR Input to target not generated by a dependency.
BUG=none
==========
to
==========
GN: Fix java_library() when supplied with a generated .java
Currently, the deps of the internal targets are setup inccorrectly:
ERROR Input to target not generated by a dependency.
BUG=none
Committed: https://crrev.com/76d9b76939631c27efafd994fbebef6bdafb4696
Cr-Commit-Position: refs/heads/master@{#395113}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/76d9b76939631c27efafd994fbebef6bdafb4696 Cr-Commit-Position: refs/heads/master@{#395113} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
