third_party/WebKit/Source/core/dom/ElementRareData.h - Issue 2001453002: Set ComputedStyle on Node and use that in buildOwnLayout()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ElementRareData.h

Issue 2001453002: Set ComputedStyle on Node and use that in buildOwnLayout() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@storage

Patch Set: Send over for review Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/dom/Node.h » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ElementRareData.h

diff --git a/third_party/WebKit/Source/core/dom/ElementRareData.h b/third_party/WebKit/Source/core/dom/ElementRareData.h

index 96c1c9dca4be1052fdee87c31cfc657ee67a9129..d31dbdf3b97733e284932b3fe46e59fdc2b11f68 100644

--- a/third_party/WebKit/Source/core/dom/ElementRareData.h

+++ b/third_party/WebKit/Source/core/dom/ElementRareData.h

@@ -100,10 +100,11 @@ public:

}

void setComputedStyle(PassRefPtr<ComputedStyle> computedStyle)

{

- if (layoutObject())

- layoutObject()->setStyleInternal(computedStyle);

- else

+ if (layoutObject()) {

+ layoutObject()->setStyleFromNodeOrElement(computedStyle);

+ } else {

m_computedStyle = computedStyle;

+ }

}

void clearComputedStyleIfNoLayoutObject()

{