Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2001453002: Set ComputedStyle on Node and use that in buildOwnLayout() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@storage
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
index a2cca350f1509490173efa3c80d9cf4fb101e60e..61af9561736e44404833ba96970536a157661639 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
@@ -427,7 +427,7 @@ void HTMLSelectElement::optionElementChildrenChanged(const HTMLOptionElement& op
{
setNeedsValidityCheck();
- if (layoutObject()) {
+ if (hasLayoutObject()) {
if (option.selected() && usesMenuList())
layoutObject()->updateFromElement();
if (AXObjectCache* cache = layoutObject()->document().existingAXObjectCache())
@@ -833,7 +833,7 @@ void HTMLSelectElement::setRecalcListItems(HTMLElement& subject)
invalidateSelectedItems();
}
- if (layoutObject()) {
+ if (hasLayoutObject()) {
if (AXObjectCache* cache = layoutObject()->document().existingAXObjectCache())
cache->childrenChanged(this);
}
@@ -1919,7 +1919,7 @@ String HTMLSelectElement::itemText(const Element& element) const
else if (isHTMLOptionElement(element))
itemString = toHTMLOptionElement(element).textIndentedToRespectGroupLabel();
- if (layoutObject())
+ if (hasLayoutObject())
applyTextTransform(layoutObject()->style(), itemString, ' ');
return itemString;
}
@@ -1977,7 +1977,7 @@ void HTMLSelectElement::popupDidHide()
void HTMLSelectElement::setIndexToSelectOnCancel(int listIndex)
{
m_indexToSelectOnCancel = listIndex;
- if (layoutObject())
+ if (hasLayoutObject())
layoutObject()->updateFromElement();
}

Powered by Google App Engine
This is Rietveld 408576698