third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp - Issue 2001453002: Set ComputedStyle on Node and use that in buildOwnLayout()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2001453002: Set ComputedStyle on Node and use that in buildOwnLayout() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@storage

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/Node.cpp ('K') | « third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFrameElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

index ca3dcf73b1f7ed8903e5f726a8ba8993f8bff51b..bc242f175eff37798e0eda8e4528f2ffe67c5f24 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

@@ -157,7 +157,7 @@ void HTMLFormControlElement::parseAttribute(const QualifiedName& name, const Ato

setNeedsWillValidateCheck();

pseudoStateChanged(CSSSelector::PseudoReadOnly);

pseudoStateChanged(CSSSelector::PseudoReadWrite);

- if (layoutObject())

+ if (hasLayoutObject())

LayoutTheme::theme().controlStateChanged(*layoutObject(), ReadOnlyControlState);

}

} else if (name == requiredAttr) {

@@ -177,7 +177,7 @@ void HTMLFormControlElement::disabledAttributeChanged()

setNeedsWillValidateCheck();

pseudoStateChanged(CSSSelector::PseudoDisabled);

pseudoStateChanged(CSSSelector::PseudoEnabled);

- if (layoutObject())

+ if (hasLayoutObject())

LayoutTheme::theme().controlStateChanged(*layoutObject(), EnabledControlState);

if (isDisabledFormControl() && adjustedFocusedElementInTreeScope() == this) {

// We might want to call blur(), but it's dangerous to dispatch events