third_party/WebKit/Source/core/dom/Node.cpp - Issue 2001453002: Set ComputedStyle on Node and use that in buildOwnLayout()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2001453002: Set ComputedStyle on Node and use that in buildOwnLayout() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@storage

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | third_party/WebKit/Source/core/dom/NodeComputedStyle.h » ('j') | third_party/WebKit/Source/core/dom/NodeComputedStyle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index e86209842349280f79a9648027506024294764b0..cd6e22a617688b217ad939ffe69358a95899f04a 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -280,9 +280,9 @@ NodeRareData& Node::ensureRareData()

return *rareData();

if (isElementNode())

- m_data.m_rareData = ElementRareData::create(m_data.m_layoutObject);

nainar 2016/07/06 07:09:03 @bugsnash, These two lines should be changed in

Bugs Nash 2016/07/06 21:32:21 Good spot

+ m_data.m_rareData = ElementRareData::create(hasLayoutObject() ? m_data.m_layoutObject : nullptr);

else

- m_data.m_rareData = NodeRareData::create(m_data.m_layoutObject);

+ m_data.m_rareData = NodeRareData::create(hasLayoutObject() ? m_data.m_layoutObject : nullptr);

DCHECK(m_data.m_rareData);