Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 2001453002: Set ComputedStyle on Node and use that in buildOwnLayout() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@storage
Patch Set: Initial review Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index 6454137452f1d4280f9507e3ef0b6eb625ea4745..754fa83e81c64a4a207e271b64bb3672f384ac2f 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -977,6 +977,8 @@ bool ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects(Frame
return false;
for (const LayoutObject* layoutObject : *viewportConstrainedObjects) {
+ if (layoutObject->node()->isPseudoElement())
sashab 2016/07/06 04:22:02 Why this?
Bugs Nash 2016/07/06 04:30:42 why is this necessary? maybe add to description
nainar 2016/07/06 04:51:53 Sorry this was a hack I had made to force a test t
+ continue;
ASSERT(layoutObject->isBoxModelObject() && layoutObject->hasLayer());
ASSERT(layoutObject->style()->position() == FixedPosition
|| layoutObject->style()->position() == StickyPosition);

Powered by Google App Engine
This is Rietveld 408576698