Set ComputedStyle on Node and use that in buildOwnLayout()

third_party/WebKit/Source/core/dom/NodeComputedStyle.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2008 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 41 matching lines @@
         return nonLayoutObjectComputedStyle();
     if (hasRareData()) {
         NodeRareData* rareData = this->rareData();
         if (!rareData->isElementRareData())
             return nullptr;
         return static_cast<ElementRareData*>(rareData)->computedStyle();
     }
     return m_data.m_computedStyle;
 }
 
+inline void Node::setComputedStyle(PassRefPtr<ComputedStyle> computedStyle)
+{
+    // printf("In Node::setComputedStyle nodeName %s hasRareData %d hasLayoutObject %d computedStyle %p\n", nodeName().ascii().data(), hasRareData(), hasLayoutObject(), mutableComputedStyle());

[Bugs Nash, 2016/08/23 02:37:52]

forgot to delete this?

+    if (hasRareData() && hasLayoutObject()) {
+        // If the DataUnion is a NodeRareDataBase and has a LayoutObject - set the ComputedStyle on that LayoutObject.
+        if (computedStyle->hasImage())
+            m_data.m_rareData->layoutObject()->setStyle(computedStyle);
+        else
+            m_data.m_rareData->layoutObject()->setStyleInternal(computedStyle);
+    } else if (hasRareData() && !hasLayoutObject()) {
+        // If the DataUnion is an NodeRareDataBase (specifically an ElementRareData) without a LayoutObject- set the ComputedStyle on that LayoutObject.

[Bugs Nash, 2016/08/23 02:37:52]

should be 'a NodeRareDataBase' and 'set the ComputedStyle on the rare data',
also missing space before dash

+        NodeRareData* rareData = this->rareData();
+        if (rareData->isElementRareData())

[Bugs Nash, 2016/08/23 02:37:52]

This should be a DCHECK. Since setComputedStyle is only ever called from
Element::recalcOwnStyle, it will never be called on a non-Element Node.

+            static_cast<ElementRareData*>(rareData)->setComputedStyle(computedStyle);
+    } else if (!hasRareData() && hasLayoutObject()) {
+        // If the DataUnion is a LayoutObject - set the ComputedStyle on that LayoutObject.
+        if (computedStyle->hasImage())
+            m_data.m_layoutObject->setStyle(computedStyle);
+        else
+            m_data.m_layoutObject->setStyleInternal(computedStyle);
+    } else {
+        // If the DataUnion is a ComputedStyle - make it point to the new ComputedStyle passed in.

[Bugs Nash, 2016/08/23 02:40:20]

this case also covers the DataUnion being null

+        if (m_data.m_computedStyle)
+            m_data.m_computedStyle->deref();
+        m_data.m_computedStyle = computedStyle.leakRef();
+    }
+}
+
 inline const ComputedStyle* Node::parentComputedStyle() const
 {
     if (isSlotOrActiveInsertionPoint())
         return 0;
     ContainerNode* parent = LayoutTreeBuilderTraversal::parent(*this);
     return parent ? parent->computedStyle() : 0;
 }
 
 inline const ComputedStyle& Node::computedStyleRef() const
 {
     const ComputedStyle* style = computedStyle();
     DCHECK(style);
     return *style;
 }
 
 } // namespace blink
 #endif // NodeComputedStyle_h