Set ComputedStyle on Node and use that in buildOwnLayout()

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 591 matching lines @@
 }
 
 LayoutBoxModelObject* Node::layoutBoxModelObject() const
 {
     LayoutObject* layoutObject = this->layoutObject();
     return layoutObject && layoutObject->isBoxModelObject() ? toLayoutBoxModelObject(layoutObject) : nullptr;
 }
 
 LayoutRect Node::boundingBox() const
 {
-    if (layoutObject())
+    if (hasLayoutObject())

[sashab, 2016/07/04 07:57:13]

I think you forgot to upload the code for this function :^)

Also, I would make this a separate patch, and say that you used find-and-replace
to make the change :)

[nainar, 2016/07/05 00:26:55]

Took a look at this. The code for hasLayoutObject is meant to be in Bugs' patch.
CodeReview sees it as landed and is hence running my code on master - which
doesn't have the code change I need since the CL got reverted. The only way I
see of overriding this setting the dependant patch to be a copy CL of Bugs'
code. And then changing that once Bugs' patch is landed. 

         return LayoutRect(layoutObject()->absoluteBoundingBoxRect());
     return LayoutRect();
 }
 
 #ifndef NDEBUG
 inline static ShadowRoot* oldestShadowRootFor(const Node* node)
 {
     if (!node->isElementNode())
         return nullptr;
     if (ElementShadow* shadow = toElement(node)->shadow())
@@ skipping 314 matching lines @@
 
     if (AXObjectCache* cache = document().axObjectCache())
         cache->updateCacheAfterNodeIsAttached(this);
 }
 
 void Node::detach(const AttachContext& context)
 {
     DCHECK(document().lifecycle().stateAllowsDetach());
     DocumentLifecycle::DetachScope willDetach(document().lifecycle());
 
-    if (layoutObject())
+    if (hasLayoutObject())
         layoutObject()->destroyAndCleanupAnonymousWrappers();
     setLayoutObject(nullptr);
     setStyleChange(NeedsReattachStyleChange);
     clearChildNeedsStyleInvalidation();
 }
 
 void Node::reattachWhitespaceSiblingsIfNeeded(Text* start)
 {
     ScriptForbiddenScope forbidScriptDuringRawIteration;
     for (Node* sibling = start; sibling; sibling = sibling->nextSibling()) {
@@ skipping 21 matching lines @@
     return 0;
 }
 
 // FIXME: Shouldn't these functions be in the editing code?  Code that asks questions about HTML in the core DOM class
 // is obviously misplaced.
 bool Node::canStartSelection() const
 {
     if (hasEditableStyle())
         return true;
 
-    if (layoutObject()) {
+    if (hasLayoutObject()) {
         const ComputedStyle& style = layoutObject()->styleRef();
         // We allow selections to begin within an element that has -webkit-user-select: none set,
         // but if the element is draggable then dragging should take priority over selection.
         if (style.userDrag() == DRAG_ELEMENT && style.userSelect() == SELECT_NONE)
             return false;
     }
     ContainerNode* parent = FlatTreeTraversal::parent(*this);
     return parent ? parent->canStartSelection() : true;
 }
 
@@ skipping 1503 matching lines @@
 
 void showNodePath(const blink::Node* node)
 {
     if (node)
         node->showNodePathForThis();
     else
         fprintf(stderr, "Cannot showNodePath for (nil)\n");
 }
 
 #endif