chrome/browser/ui/views/location_bar/background_with_1_px_border.cc - Issue 2001433002: Update appearance of omnibox focus for MD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/background_with_1_px_border.cc

Issue 2001433002: Update appearance of omnibox focus for MD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: share constant Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/background_with_1_px_border.h ('k') | chrome/browser/ui/views/location_bar/location_bar_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/background_with_1_px_border.cc

diff --git a/chrome/browser/ui/views/location_bar/background_with_1_px_border.cc b/chrome/browser/ui/views/location_bar/background_with_1_px_border.cc

index d62f030c2fbff7fc519e645fd81fc1cb9045f2e1..8fdff449e6d6c5117867a4e62034544fdcedd03f 100644

--- a/chrome/browser/ui/views/location_bar/background_with_1_px_border.cc

+++ b/chrome/browser/ui/views/location_bar/background_with_1_px_border.cc

@@ -13,6 +13,9 @@

#include "ui/views/view.h"

#include "ui/views/widget/widget.h"

+// static

+const float BackgroundWith1PxBorder::kCornerRadius = 2.5f;

BackgroundWith1PxBorder::BackgroundWith1PxBorder(SkColor background,

SkColor border)

: border_color_(border) {

@@ -31,9 +34,9 @@ void BackgroundWith1PxBorder::Paint(gfx::Canvas* canvas,

border_rect_f.Inset(inset, inset);

SkPath path;

- const SkScalar kCornerRadius = SkDoubleToScalar(2.5f * scale);

- path.addRoundRect(gfx::RectFToSkRect(border_rect_f), kCornerRadius,

- kCornerRadius);

+ const SkScalar scaled_corner_radius = SkFloatToScalar(kCornerRadius * scale);

+ path.addRoundRect(gfx::RectFToSkRect(border_rect_f), scaled_corner_radius,

+ scaled_corner_radius);

SkPaint paint;

paint.setStyle(SkPaint::kStroke_Style);