Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2001403003: kiosk: Fix AppsMenu.findAndRunAppForTesting js error (Closed)

Created:
4 years, 7 months ago by xiyuan
Modified:
4 years, 7 months ago
Reviewers:
achuithb, jennyz
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: Fix AppsMenu.findAndRunAppForTesting js error AppsMenu.findAndRunAppForTesting depends on whether "Apps" menu is visible or not and is flaky on bots. The method should launch the app regardless of whether the menu itself is visible or not. Change the impl to use its internal data to launch the app. BUG=612688 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8e37ebd0270bba886594552f9b79c10b50d3c0dc Cr-Commit-Position: refs/heads/master@{#395706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M chrome/browser/resources/chromeos/login/apps_menu.js View 2 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
xiyuan
4 years, 7 months ago (2016-05-24 21:02:28 UTC) #3
achuithb
lgtm++
4 years, 7 months ago (2016-05-24 21:18:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001403003/1
4 years, 7 months ago (2016-05-24 21:20:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 21:48:14 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 21:50:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e37ebd0270bba886594552f9b79c10b50d3c0dc
Cr-Commit-Position: refs/heads/master@{#395706}

Powered by Google App Engine
This is Rietveld 408576698